Re: [PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-22 Thread Thomas Gleixner
On Wed, 21 Jan 2015, Paul E. McKenney wrote: > On Wed, Jan 21, 2015 at 10:30:07AM +0100, Thomas Gleixner wrote: > > On Tue, 20 Jan 2015, Paul E. McKenney wrote: > > > On Tue, Jan 20, 2015 at 02:21:51PM +0100, Thomas Gleixner wrote: > > > > The whole rcu_note_context_switch() in run_ksoftirqd() is s

Re: [PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-21 Thread Paul E. McKenney
On Wed, Jan 21, 2015 at 10:30:07AM +0100, Thomas Gleixner wrote: > On Tue, 20 Jan 2015, Paul E. McKenney wrote: > > On Tue, Jan 20, 2015 at 02:21:51PM +0100, Thomas Gleixner wrote: > > > The whole rcu_note_context_switch() in run_ksoftirqd() is silly. > > > > > > cond_resched() > > > __preem

Re: [PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-21 Thread Thomas Gleixner
On Tue, 20 Jan 2015, Paul E. McKenney wrote: > On Tue, Jan 20, 2015 at 02:21:51PM +0100, Thomas Gleixner wrote: > > The whole rcu_note_context_switch() in run_ksoftirqd() is silly. > > > > cond_resched() > > __preempt_count_add(PREEMPT_ACTIVE); > > > > __schedule(); > > preem

Re: [PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-20 Thread Mike Galbraith
On Tue, 2015-01-20 at 21:10 -0800, Paul E. McKenney wrote: > On Wed, Jan 21, 2015 at 04:40:39AM +0100, Mike Galbraith wrote: > > I've been curious about this for ages, so now is a great time to bite > > the bullet and ask TheMan. A context switch is not far away, why do we > > need that quiescen

Re: [PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-20 Thread Paul E. McKenney
On Wed, Jan 21, 2015 at 04:40:39AM +0100, Mike Galbraith wrote: > On Tue, 2015-01-20 at 12:30 -0800, Paul E. McKenney wrote: > > On Tue, Jan 20, 2015 at 02:21:51PM +0100, Thomas Gleixner wrote: > > > > > diff --git a/kernel/softirq.c b/kernel/softirq.c > > > > index 501baa9..9e787d8 100644 > > >

Re: [PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-20 Thread Mike Galbraith
On Tue, 2015-01-20 at 12:30 -0800, Paul E. McKenney wrote: > On Tue, Jan 20, 2015 at 02:21:51PM +0100, Thomas Gleixner wrote: > > > diff --git a/kernel/softirq.c b/kernel/softirq.c > > > index 501baa9..9e787d8 100644 > > > --- a/kernel/softirq.c > > > +++ b/kernel/softirq.c > > > @@ -656,9 +656,1

Re: [PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-20 Thread Paul E. McKenney
On Tue, Jan 20, 2015 at 02:21:51PM +0100, Thomas Gleixner wrote: > On Tue, 13 Jan 2015, Calvin Owens wrote: > > > While debugging an issue with excessive softirq usage, I encountered the > > following note in commit 3e339b5dae24a706 ("softirq: Use hotplug thread > > infrastructure"): > > > >

Re: [PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-20 Thread Thomas Gleixner
On Tue, 13 Jan 2015, Calvin Owens wrote: > While debugging an issue with excessive softirq usage, I encountered the > following note in commit 3e339b5dae24a706 ("softirq: Use hotplug thread > infrastructure"): > > [ paulmck: Call rcu_note_context_switch() with interrupts enabled. ] > > ...bu

Re: [PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-14 Thread Paul E. McKenney
On Tue, Jan 13, 2015 at 01:16:18PM -0800, Calvin Owens wrote: > While debugging an issue with excessive softirq usage, I encountered the > following note in commit 3e339b5dae24a706 ("softirq: Use hotplug thread > infrastructure"): > > [ paulmck: Call rcu_note_context_switch() with interrupts e

[PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-13 Thread Calvin Owens
While debugging an issue with excessive softirq usage, I encountered the following note in commit 3e339b5dae24a706 ("softirq: Use hotplug thread infrastructure"): [ paulmck: Call rcu_note_context_switch() with interrupts enabled. ] ...but despite this note, the patch still calls RCU with IRQs

[PATCH] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

2015-01-06 Thread Calvin Owens
While debugging an issue with excessive softirq usage, I encountered the following note in commit 3e339b5dae24a706 ("softirq: Use hotplug thread infrastructure"): [ paulmck: Call rcu_note_context_switch() with interrupts enabled. ] ...but despite this note, the patch still calls RCU with IRQs