Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-23 Thread Christian Borntraeger
On 23.01.2019 00:11, Paolo Bonzini wrote: > On 22/01/19 21:48, Greg Kroah-Hartman wrote: >>> This also brings the question: shall we move these counters out of debugfs >>> into something else? >> If you have code that relies on debugfs, yes, you need to move that out >> of debugfs because more

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Paolo Bonzini
On 22/01/19 21:48, Greg Kroah-Hartman wrote: >> This also brings the question: shall we move these counters out of debugfs >> into something else? > If you have code that relies on debugfs, yes, you need to move that out > of debugfs because more and more systems are trying to disable it due to >

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Greg Kroah-Hartman
On Tue, Jan 22, 2019 at 09:39:24PM +0100, Christian Borntraeger wrote: > > > On 22.01.2019 16:21, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something diff

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Christian Borntraeger
On 22.01.2019 16:21, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc: k...@vger

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Greg Kroah-Hartman
On Tue, Jan 22, 2019 at 09:29:07AM -0800, Sean Christopherson wrote: > On Tue, Jan 22, 2019 at 09:21:02AM -0800, Sean Christopherson wrote: > > On Tue, Jan 22, 2019 at 04:21:50PM +0100, Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is no need to ever check the > > > return v

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Sean Christopherson
On Tue, Jan 22, 2019 at 09:21:02AM -0800, Sean Christopherson wrote: > On Tue, Jan 22, 2019 at 04:21:50PM +0100, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do s

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Sean Christopherson
On Tue, Jan 22, 2019 at 04:21:50PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. What about wanting to make the debugfs all

[PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Paolo Bonzini Cc: "Radim Krčmář" Cc: k...@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- virt/kvm/kvm