Re: [PATCH] kvm: x86: Use KVM CPU capabilities to determine CR4 reserved bits

2020-05-18 Thread Xiaoyao Li
On 5/18/2020 8:31 PM, Paolo Bonzini wrote: On 18/05/20 06:52, Xiaoyao Li wrote: On 5/6/2020 5:44 PM, Paolo Bonzini wrote: Using CPUID data can be useful for the processor compatibility check, but that's it.  Using it to compute guest-reserved bits can have both false positives (such as LA57

Re: [PATCH] kvm: x86: Use KVM CPU capabilities to determine CR4 reserved bits

2020-05-18 Thread Paolo Bonzini
On 18/05/20 06:52, Xiaoyao Li wrote: > On 5/6/2020 5:44 PM, Paolo Bonzini wrote: >> Using CPUID data can be useful for the processor compatibility >> check, but that's it.  Using it to compute guest-reserved bits >> can have both false positives (such as LA57 and UMIP which we >> are already

Re: [PATCH] kvm: x86: Use KVM CPU capabilities to determine CR4 reserved bits

2020-05-17 Thread Xiaoyao Li
On 5/6/2020 5:44 PM, Paolo Bonzini wrote: Using CPUID data can be useful for the processor compatibility check, but that's it. Using it to compute guest-reserved bits can have both false positives (such as LA57 and UMIP which we are already handling) and false negatives: in particular, with

[PATCH] kvm: x86: Use KVM CPU capabilities to determine CR4 reserved bits

2020-05-06 Thread Paolo Bonzini
Using CPUID data can be useful for the processor compatibility check, but that's it. Using it to compute guest-reserved bits can have both false positives (such as LA57 and UMIP which we are already handling) and false negatives: in particular, with this patch we don't allow anymore a KVM guest