Re: [PATCH] kvm: x86: limit the maximum number of vPMU fixed counters to 3

2020-07-08 Thread Xu, Like
On 2020/7/8 19:09, Paolo Bonzini wrote: On 08/07/20 09:51, Xu, Like wrote: Kindly ping. I think we may need this patch, as we limit the maximum vPMU version to 2:     eax.split.version_id = min(cap.version, 2); I don't think this is a problem. Are you planning to add support for the fourth c

Re: [PATCH] kvm: x86: limit the maximum number of vPMU fixed counters to 3

2020-07-08 Thread Paolo Bonzini
On 08/07/20 09:51, Xu, Like wrote: > Kindly ping. > > I think we may need this patch, as we limit the maximum vPMU version to 2: >     eax.split.version_id = min(cap.version, 2); I don't think this is a problem. Are you planning to add support for the fourth counter? Paolo

Re: [PATCH] kvm: x86: limit the maximum number of vPMU fixed counters to 3

2020-07-08 Thread Paolo Bonzini
On 24/06/20 03:59, Like Xu wrote: > Some new Intel platforms (such as TGL) already have the > fourth fixed counter TOPDOWN.SLOTS, but it has not been > fully enabled on KVM and the host. > > Therefore, we limit edx.split.num_counters_fixed to 3, > so that it does not break the kvm-unit-tests PMU t

Re: [PATCH] kvm: x86: limit the maximum number of vPMU fixed counters to 3

2020-07-08 Thread Xu, Like
Kindly ping. I think we may need this patch, as we limit the maximum vPMU version to 2:     eax.split.version_id = min(cap.version, 2); Thanks, Like Xu On 2020/6/24 9:59, Like Xu wrote: Some new Intel platforms (such as TGL) already have the fourth fixed counter TOPDOWN.SLOTS, but it has not b

[PATCH] kvm: x86: limit the maximum number of vPMU fixed counters to 3

2020-06-23 Thread Like Xu
Some new Intel platforms (such as TGL) already have the fourth fixed counter TOPDOWN.SLOTS, but it has not been fully enabled on KVM and the host. Therefore, we limit edx.split.num_counters_fixed to 3, so that it does not break the kvm-unit-tests PMU test case and bad-handled userspace. Signed-of