Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
Thanks, I found the cause, the delta patch is submitted. Lan7430 runs now in different speeds, also ‚hot swap‘ between different speeds works well. Normal mode and fixed-phy mode coexist properly. So, I guess we’re done :) However, I’ll spend some more time testing to ensure we’re really safe.

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
I’m testing with Microchip Lan7430, which is an integrated circuit that contains MAC and PHY in one package. With the release kernel the hardware works fine, so the overall configuration is ok (jumpers). I will verify wether the effective RGMII and delay settings, you mention, are equal in

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Andrew Lunn
On Wed, Jun 03, 2020 at 06:33:28PM +0200, Roelof Berg wrote: > Ok, let's proceed :) The code runs well, dmesg looks good, ip addr shows me a > link up, speed/duplex looks ok. But it does not transfer any data. > > Debugging steps (A/B versions): > - Check clocks with oscilloscope (10/100/1000) >

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Andrew Lunn
On Wed, Jun 03, 2020 at 06:36:28PM +0200, Roelof Berg wrote: > If I find a fix, would I need to submit a delta patch (to our last one) or a > full patch ? A delta. Andrew

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
If I find a fix, would I need to submit a delta patch (to our last one) or a full patch ? Thanks. > So lets try to fix it. > >Thanks > Andrew >

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
Ok, let's proceed :) The code runs well, dmesg looks good, ip addr shows me a link up, speed/duplex looks ok. But it does not transfer any data. Debugging steps (A/B versions): - Check clocks with oscilloscope (10/100/1000) - Dump actual register settings - Trace Phy-Phy autonegotiation and

Re: [PATCH] lan743x: Added fixed link and RGMII support / BROKEN PATCH

2020-06-03 Thread Andrew Lunn
On Wed, Jun 03, 2020 at 04:52:32PM +0200, Roelof Berg wrote: > TEST REPORT: BROKEN PATCH > > Thanks to everyone for working on the fixed link feature of lan743x eth > driver. > > I received more test hardware today, and one piece of hardware > (EVBlan7430) becomes incompatible by the patch. We

Re: [PATCH] lan743x: Added fixed link and RGMII support / Options for proceeding ?

2020-06-03 Thread Roelof Berg
Hi, we need to decide how to continue with the lan743x patch for fixed phy support. Thanks everyone for the valuable time. Summary of the development steps so far: The patch initially had low influence on the installed base, but lacked some compatibility to Linux best practices. During the

Re: [PATCH] lan743x: Added fixed link and RGMII support / BROKEN PATCH

2020-06-03 Thread Roelof Berg
TEST REPORT: BROKEN PATCH Thanks to everyone for working on the fixed link feature of lan743x eth driver. I received more test hardware today, and one piece of hardware (EVBlan7430) becomes incompatible by the patch. We need to roll back for now. Sorry. I’ll discuss about options of how to

Re: [PATCH] lan743x: Added fixed link and RGMII support

2020-06-01 Thread David Miller
From: Roelof Berg Date: Fri, 29 May 2020 21:30:02 +0200 > Microchip lan7431 is frequently connected to a phy. However, it > can also be directly connected to a MII remote peer without > any phy in between. For supporting such a phyless hardware setup > in Linux we utilized phylib, which supports

Re: [PATCH] lan743x: Added fixed link and RGMII support

2020-05-29 Thread Andrew Lunn
On Fri, May 29, 2020 at 09:30:02PM +0200, Roelof Berg wrote: > Microchip lan7431 is frequently connected to a phy. However, it > can also be directly connected to a MII remote peer without > any phy in between. For supporting such a phyless hardware setup > in Linux we utilized phylib, which

[PATCH] lan743x: Added fixed link and RGMII support

2020-05-29 Thread Roelof Berg
Microchip lan7431 is frequently connected to a phy. However, it can also be directly connected to a MII remote peer without any phy in between. For supporting such a phyless hardware setup in Linux we utilized phylib, which supports a fixed-link configuration via the device tree. And we added