Re: [PATCH] led/ledtrig-heartbeat: Convert timers to use

2017-10-06 Thread Kees Cook
On Fri, Oct 6, 2017 at 1:18 PM, Jacek Anaszewski wrote: > Hi Kees, > > Thanks for the patch. > > On 10/05/2017 02:49 AM, Kees Cook wrote: >> Instead of using .data directly, convert to from_timer. Since the >> trigger_data is allocated separately, the led_cdev must be explicitly >> tracked for the

Re: [PATCH] led/ledtrig-heartbeat: Convert timers to use

2017-10-06 Thread Jacek Anaszewski
Hi Kees, Thanks for the patch. On 10/05/2017 02:49 AM, Kees Cook wrote: > Instead of using .data directly, convert to from_timer. Since the > trigger_data is allocated separately, the led_cdev must be explicitly > tracked for the callback. > > Cc: Richard Purdie > Cc: Jacek Anaszewski > Cc: Pa

[PATCH] led/ledtrig-heartbeat: Convert timers to use

2017-10-04 Thread Kees Cook
Instead of using .data directly, convert to from_timer. Since the trigger_data is allocated separately, the led_cdev must be explicitly tracked for the callback. Cc: Richard Purdie Cc: Jacek Anaszewski Cc: Pavel Machek Cc: Zhang Bo Cc: Linus Walleij Cc: Ingo Molnar Cc: linux-l...@vger.kernel