Re: [PATCH] leds: Add arbitrary pattern trigger

2015-03-16 Thread Raphaël Teysseyre
> Got this while playing with my hid-sony patches: Sorry about that, it's me being dumb and using a mutex in an atomic context... Raphaël -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

Re: [PATCH] leds: Add arbitrary pattern trigger

2015-03-16 Thread Paul Bolle
Just a license nit. On Mon, 2015-03-16 at 11:06 +0100, Raphaël Teysseyre wrote: > --- /dev/null > +++ b/drivers/leds/trigger/ledtrig-pattern.c > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * p

Re: [PATCH] leds: Add arbitrary pattern trigger

2015-03-16 Thread Pavel Machek
Hi! I'd really return error if we can't parse user's input. Small spelling fixes: --- drivers/leds/trigger/ledtrig-pattern.c~ 2015-03-16 12:07:06.897408622 +0100 +++ drivers/leds/trigger/ledtrig-pattern.c 2015-03-16 13:08:25.801864534 +0100 @@ -38,7 +38,7 @@ int nsteps; /* Nu

Re: [PATCH] leds: Add arbitrary pattern trigger

2015-03-16 Thread Pavel Machek
Hi! > Additional testing and comments would be appreciated. git complains about newline at EOF. Nice ascii art ;-). Got this while playing with my hid-sony patches: [ 460.025901] snd_hda_intel :00:1b.0: IRQ timing workaround is activated for card #0. Suggest a bigger bdl_pos_adj. [ 826.1

[PATCH] leds: Add arbitrary pattern trigger

2015-03-16 Thread Raphaël Teysseyre
Hi all, Following our discussion about [PATCH RFC] leds: Add status code trigger, here is a patch allowing arbitrary patterns. This is intended for embedded systems without screen or network access to show a status (or error) code to a human. It's been tested on an ARM architecture (Xilinx Zynq 7