Re: [PATCH] leds: Added driver for the NXP PCA9685 I2C chip

2013-10-14 Thread Jingoo Han
On Tuesday, October 15, 2013 2:32 AM, Maximilian Guntner wrote: > > The NXP PCA9685 supports 16 channels/leds using a 12-bit PWM (4095 > levels of brightness) > This driver supports configuration using platform_data. > > Signed-off-by: Maximilian Güntner I added some nit-picking comments. :-)

Re: [PATCH] leds: Added driver for the NXP PCA9685 I2C chip

2013-10-14 Thread Maximilian Güntner
On Monday 14 October 2013 15:08:15 Bryan Wu wrote: > On Mon, Oct 14, 2013 at 10:31 AM, Maximilian Güntner > > wrote: > > The NXP PCA9685 supports 16 channels/leds using a 12-bit PWM (4095 > > levels of brightness) > > This driver supports configuration using platform_data. > > I'm OK for this pa

Re: [PATCH] leds: Added driver for the NXP PCA9685 I2C chip

2013-10-14 Thread Maximilian Güntner
On Tuesday 15 October 2013 00:38:13 Peter Meerwald wrote: > > The NXP PCA9685 supports 16 channels/leds using a 12-bit PWM (4095 > > levels of brightness) > > This driver supports configuration using platform_data. > > some nitpicking inline Thank you for your comments. > chip fixed. > >> + * Dri

Re: [PATCH] leds: Added driver for the NXP PCA9685 I2C chip

2013-10-14 Thread Peter Meerwald
> The NXP PCA9685 supports 16 channels/leds using a 12-bit PWM (4095 > levels of brightness) > This driver supports configuration using platform_data. some nitpicking inline > Signed-off-by: Maximilian Güntner > --- > drivers/leds/Kconfig | 10 ++ > drivers/leds/Makefil

Re: [PATCH] leds: Added driver for the NXP PCA9685 I2C chip

2013-10-14 Thread Bryan Wu
On Mon, Oct 14, 2013 at 10:31 AM, Maximilian Güntner wrote: > The NXP PCA9685 supports 16 channels/leds using a 12-bit PWM (4095 > levels of brightness) > This driver supports configuration using platform_data. > I'm OK for this patch basically, just a little picky coding style issue as below. T

[PATCH] leds: Added driver for the NXP PCA9685 I2C chip

2013-10-14 Thread Maximilian Güntner
The NXP PCA9685 supports 16 channels/leds using a 12-bit PWM (4095 levels of brightness) This driver supports configuration using platform_data. Signed-off-by: Maximilian Güntner --- drivers/leds/Kconfig | 10 ++ drivers/leds/Makefile | 1 + drivers/