Re: [PATCH] leds: add NCT6795D driver

2020-07-20 Thread Pavel Machek
Hi! > > According to common LED bindings you should propose a new function > > if none of the existing ones fits your needs. > > > > > This is normally used for motherboard lightning, right? I believe this > > > is getting common on gaming boards, and we want common support for > > > that. > > >

Re: [PATCH] leds: add NCT6795D driver

2020-07-20 Thread Alexandre Courbot
On Sat, Jul 18, 2020 at 4:25 AM Jacek Anaszewski wrote: > > > >> The reason for not having a function at the moment is that I took a > >> look at include/dt-bindings/leds/common.h and could not find any > >> function that could reasonably apply. This basically controls a RGB > >> connector on the

Re: [PATCH] leds: add NCT6795D driver

2020-07-17 Thread Jacek Anaszewski
On 7/17/20 9:44 AM, Pavel Machek wrote: Hi! Add support for the LED feature of the NCT6795D chip found on some motherboards, notably MSI ones. The LEDs are typically used using a RGB connector so this driver creates one LED device for each color component. Ok, let me take a look. What

Re: [PATCH] leds: add NCT6795D driver

2020-07-17 Thread Pavel Machek
Hi! > > >>> Add support for the LED feature of the NCT6795D chip found on some > > >>> motherboards, notably MSI ones. The LEDs are typically used using a > > >>> RGB connector so this driver creates one LED device for each color > > >>> component. > > >> > > >> Ok, let me take a look. What

Re: [PATCH] leds: add NCT6795D driver

2020-07-16 Thread Alexandre Courbot
Hi Jacek, On Thu, Jul 16, 2020 at 4:32 AM Jacek Anaszewski wrote: > > Hi Alexandre, > > On 7/15/20 3:54 AM, Alexandre Courbot wrote: > > Hi Pavel, > > > > On Wed, Jul 15, 2020 at 7:33 AM Pavel Machek wrote: > >> > >> Hi! > >> > >>> Add support for the LED feature of the NCT6795D chip found on

Re: [PATCH] leds: add NCT6795D driver

2020-07-15 Thread Jacek Anaszewski
Hi Alexandre, On 7/15/20 3:54 AM, Alexandre Courbot wrote: Hi Pavel, On Wed, Jul 15, 2020 at 7:33 AM Pavel Machek wrote: Hi! Add support for the LED feature of the NCT6795D chip found on some motherboards, notably MSI ones. The LEDs are typically used using a RGB connector so this driver

Re: [PATCH] leds: add NCT6795D driver

2020-07-14 Thread Alexandre Courbot
Hi Pavel, On Wed, Jul 15, 2020 at 7:33 AM Pavel Machek wrote: > > Hi! > > > Add support for the LED feature of the NCT6795D chip found on some > > motherboards, notably MSI ones. The LEDs are typically used using a > > RGB connector so this driver creates one LED device for each color > >

Re: [PATCH] leds: add NCT6795D driver

2020-07-14 Thread Pavel Machek
Hi! > Add support for the LED feature of the NCT6795D chip found on some > motherboards, notably MSI ones. The LEDs are typically used using a > RGB connector so this driver creates one LED device for each color > component. Ok, let me take a look. What entries does it present in /sys? We'll

[PATCH] leds: add NCT6795D driver

2020-07-13 Thread Alexandre Courbot
Add support for the LED feature of the NCT6795D chip found on some motherboards, notably MSI ones. The LEDs are typically used using a RGB connector so this driver creates one LED device for each color component. Also add self as maintainer. Signed-off-by: Alexandre Courbot --- MAINTAINERS