Re: [PATCH] leds: fix a potential NULL pointer dereference

2019-04-02 Thread Jacek Anaszewski
Hi Geert, On 4/1/19 9:08 AM, Geert Uytterhoeven wrote: Hi Jacek, On Sun, Mar 31, 2019 at 1:01 PM Jacek Anaszewski wrote: On 3/31/19 11:06 AM, Geert Uytterhoeven wrote: On Sun, Mar 10, 2019 at 9:40 PM Jacek Anaszewski wrote: On 3/9/19 7:04 AM, Kangjie Lu wrote: In case of_match_device cann

Re: [PATCH] leds: fix a potential NULL pointer dereference

2019-04-01 Thread Geert Uytterhoeven
Hi Jacek, On Sun, Mar 31, 2019 at 1:01 PM Jacek Anaszewski wrote: > On 3/31/19 11:06 AM, Geert Uytterhoeven wrote: > On Sun, Mar 10, 2019 at 9:40 PM Jacek Anaszewski > > wrote: > >> On 3/9/19 7:04 AM, Kangjie Lu wrote: > >>> In case of_match_device cannot find a match, the fixes returns > >>> -E

Re: [PATCH] leds: fix a potential NULL pointer dereference

2019-03-31 Thread Jacek Anaszewski
Hi Geert, Thank you for the notification. On 3/31/19 11:06 AM, Geert Uytterhoeven wrote: Hi Jacek, On Sun, Mar 10, 2019 at 9:40 PM Jacek Anaszewski wrote: On 3/9/19 7:04 AM, Kangjie Lu wrote: In case of_match_device cannot find a match, the fixes returns -EINVAL to avoid NULL pointer derefe

Re: [PATCH] leds: fix a potential NULL pointer dereference

2019-03-31 Thread Jacek Anaszewski
Hi Linus, Yesterday I submitted pull request [0] containing this patch, but the patch turns out to be pointless. Since I see my pull request merged on top of mainline trunk I suspect it will not be a problem to drop the patch or even whole pull request. In the latter case I'll re-submit it for -r

Re: [PATCH] leds: fix a potential NULL pointer dereference

2019-03-31 Thread Geert Uytterhoeven
Hi Jacek, On Sun, Mar 10, 2019 at 9:40 PM Jacek Anaszewski wrote: > On 3/9/19 7:04 AM, Kangjie Lu wrote: > > In case of_match_device cannot find a match, the fixes returns > > -EINVAL to avoid NULL pointer dereference. > > > > Signed-off-by: Kangjie Lu > > --- > > drivers/leds/leds-pca9532.c |

Re: [PATCH] leds: fix a potential NULL pointer dereference

2019-03-11 Thread Enrico Weigelt, metux IT consult
On 10.03.19 21:27, Jacek Anaszewski wrote: > Hi Kangjie, > > Thank you for the patch. > > On 3/9/19 7:04 AM, Kangjie Lu wrote: >> In case of_match_device cannot find a match, the fixes returns >> -EINVAL to avoid NULL pointer dereference. >> >> Signed-off-by: Kangjie Lu >> --- >>   drivers/leds/

Re: [PATCH] leds: fix a potential NULL pointer dereference

2019-03-10 Thread Jacek Anaszewski
Hi Kangjie, Thank you for the patch. On 3/9/19 7:04 AM, Kangjie Lu wrote: In case of_match_device cannot find a match, the fixes returns -EINVAL to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/leds/leds-pca9532.c | 8 ++-- 1 file changed, 6 insertions(+), 2 del

[PATCH] leds: fix a potential NULL pointer dereference

2019-03-08 Thread Kangjie Lu
In case of_match_device cannot find a match, the fixes returns -EINVAL to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/leds/leds-pca9532.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.