Re: [PATCH] leds: ktd2692: Add missing of_node_put

Hi Rob, Jacek You're right, It is better to remove "return 0" Thanks for the review. On 2015년 11월 16일 23:30, Jacek Anaszewski wrote: > On 11/16/2015 03:09 PM, Rob Herring wrote: >> On Mon, Nov 16, 2015 at 4:00 AM, Jacek Anaszewski >> wrote: >>> Hi Ingi, Rob, >>> >>> With this patch we will be

Re: [PATCH] leds: ktd2692: Add missing of_node_put

On 11/16/2015 03:09 PM, Rob Herring wrote: On Mon, Nov 16, 2015 at 4:00 AM, Jacek Anaszewski wrote: Hi Ingi, Rob, With this patch we will be leaking of_node when parsing succeeds. I think that "return 0" should be removed. I can remove it and apply, provided that Rob's ack is still in force

Re: [PATCH] leds: ktd2692: Add missing of_node_put

On Mon, Nov 16, 2015 at 4:00 AM, Jacek Anaszewski wrote: > Hi Ingi, Rob, > > With this patch we will be leaking of_node when parsing succeeds. > I think that "return 0" should be removed. I can remove it and apply, > provided that Rob's ack is still in force with this. Rob? Okay. Rob > > Best

Re: [PATCH] leds: ktd2692: Add missing of_node_put

Hi Ingi, Rob, With this patch we will be leaking of_node when parsing succeeds. I think that "return 0" should be removed. I can remove it and apply, provided that Rob's ack is still in force with this. Rob? Best Regards, Jacek Anaszewski On 11/10/2015 04:00 AM, Ingi Kim wrote: The refcount

Re: [PATCH] leds: ktd2692: Add missing of_node_put

On Mon, Nov 16, 2015 at 4:00 AM, Jacek Anaszewski wrote: > Hi Ingi, Rob, > > With this patch we will be leaking of_node when parsing succeeds. > I think that "return 0" should be removed. I can remove it and apply, > provided that Rob's ack is still in force with this.

Re: [PATCH] leds: ktd2692: Add missing of_node_put

On 11/16/2015 03:09 PM, Rob Herring wrote: On Mon, Nov 16, 2015 at 4:00 AM, Jacek Anaszewski wrote: Hi Ingi, Rob, With this patch we will be leaking of_node when parsing succeeds. I think that "return 0" should be removed. I can remove it and apply, provided that

Re: [PATCH] leds: ktd2692: Add missing of_node_put

Hi Rob, Jacek You're right, It is better to remove "return 0" Thanks for the review. On 2015년 11월 16일 23:30, Jacek Anaszewski wrote: > On 11/16/2015 03:09 PM, Rob Herring wrote: >> On Mon, Nov 16, 2015 at 4:00 AM, Jacek Anaszewski >> wrote: >>> Hi Ingi, Rob, >>> >>>

Re: [PATCH] leds: ktd2692: Add missing of_node_put

Hi Ingi, Rob, With this patch we will be leaking of_node when parsing succeeds. I think that "return 0" should be removed. I can remove it and apply, provided that Rob's ack is still in force with this. Rob? Best Regards, Jacek Anaszewski On 11/10/2015 04:00 AM, Ingi Kim wrote: The refcount

Re: [PATCH] leds: ktd2692: Add missing of_node_put

On Mon, Nov 9, 2015 at 9:00 PM, Ingi Kim wrote: > The refcount of device_node increases after of_node_get() is called. > So, a break out of the loop requires of_node_put(). > > This patch adds missing of_node_put() when loop breaks. > > Signed-off-by: Ingi Kim Acked-by: Rob Herring > --- >

Re: [PATCH] leds: ktd2692: Add missing of_node_put

On Mon, Nov 9, 2015 at 9:00 PM, Ingi Kim wrote: > The refcount of device_node increases after of_node_get() is called. > So, a break out of the loop requires of_node_put(). > > This patch adds missing of_node_put() when loop breaks. > > Signed-off-by: Ingi Kim

[PATCH] leds: ktd2692: Add missing of_node_put

The refcount of device_node increases after of_node_get() is called. So, a break out of the loop requires of_node_put(). This patch adds missing of_node_put() when loop breaks. Signed-off-by: Ingi Kim --- drivers/leds/leds-ktd2692.c | 11 --- 1 file changed, 8 insertions(+), 3

[PATCH] leds: ktd2692: Add missing of_node_put

The refcount of device_node increases after of_node_get() is called. So, a break out of the loop requires of_node_put(). This patch adds missing of_node_put() when loop breaks. Signed-off-by: Ingi Kim --- drivers/leds/leds-ktd2692.c | 11 --- 1 file changed, 8