Re: [PATCH] leds: tlc591xx: fix device_node_continue.cocci warnings (fwd)

2018-12-07 Thread Julia Lawall
On Fri, 7 Dec 2018, Jacek Anaszewski wrote: > Hi Julia, > > Thank you for the patch, but it doesn't apply to LED tree. > > The patch causing the problem is out-of-LED-tree. OK, I guess that the patch is in a TI-specific tree, given the name. Thanks for looking into it. julia > > Best regard

Re: [PATCH] leds: tlc591xx: fix device_node_continue.cocci warnings (fwd)

2018-12-07 Thread Jacek Anaszewski
Hi Julia, Thank you for the patch, but it doesn't apply to LED tree. The patch causing the problem is out-of-LED-tree. Best regards, Jacek Anaszewski On 12/6/18 9:28 PM, Julia Lawall wrote: Hello, The code seems to be wrong in several ways. If the continue is wanted, the of_node_put is not

Re: [PATCH] leds: tlc591xx: fix device_node_continue.cocci warnings (fwd)

2018-12-06 Thread Pavel Machek
On Thu 2018-12-06 21:28:16, Julia Lawall wrote: > Hello, > > The code seems to be wrong in several ways. If the continue is wanted, > the of_node_put is not needed; it will happen on the next iteration. If > the continue is not wanted, the of_node_put is needed, and the continue > should be drop

[PATCH] leds: tlc591xx: fix device_node_continue.cocci warnings (fwd)

2018-12-06 Thread Julia Lawall
Hello, The code seems to be wrong in several ways. If the continue is wanted, the of_node_put is not needed; it will happen on the next iteration. If the continue is not wanted, the of_node_put is needed, and the continue should be dropped. julia -- Forwarded message -- Date: T