Re: [PATCH] leds: trigger: fix potential deadlock with libata

2021-03-08 Thread Marc Kleine-Budde
On 08.03.2021 15:56:53, Marc Kleine-Budde wrote: > > > meanwhile this patch hit v5.10.x stable and caused a performance > > > degradation on our use case: > > > > > > It's an embedded ARM system, 4x Cortex A53, with an SPI attached CAN > > > controller. CAN stands for Controller Area Network and

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2021-03-08 Thread Marc Kleine-Budde
On 07.03.2021 10:02:32, Boqun Feng wrote: > On Sat, Mar 06, 2021 at 09:39:54PM +0100, Marc Kleine-Budde wrote: > > Hello *, > > > > On 02.11.2020 11:41:52, Andrea Righi wrote: > > > We have the following potential deadlock condition: > > > > > >

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2021-03-07 Thread Hans de Goede
Hi, On 3/7/21 5:13 PM, Pavel Machek wrote: > Hi! > >>> --- a/drivers/leds/led-triggers.c >>> +++ b/drivers/leds/led-triggers.c >>> @@ -378,14 +378,15 @@ void led_trigger_event(struct led_trigger *trig, >>> enum led_brightness brightness) >>> { >>> struct led_classdev

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2021-03-07 Thread Pavel Machek
Hi! > > --- > > drivers/leds/led-triggers.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c > > index 91da90cfb11d..16d1a93a10a8 100644 > > --- a/drivers/leds/led-triggers.c > > +++

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2021-03-07 Thread Pavel Machek
Hi! > > --- a/drivers/leds/led-triggers.c > > +++ b/drivers/leds/led-triggers.c > > @@ -378,14 +378,15 @@ void led_trigger_event(struct led_trigger *trig, > > enum led_brightness brightness) > > { > > struct led_classdev *led_cdev; > > + unsigned long flags; > > > >

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2021-03-06 Thread Andrea Righi
On Sun, Mar 07, 2021 at 10:02:32AM +0800, Boqun Feng wrote: > On Sat, Mar 06, 2021 at 09:39:54PM +0100, Marc Kleine-Budde wrote: > > Hello *, > > > > On 02.11.2020 11:41:52, Andrea Righi wrote: > > > We have the following potential deadlock condition: > > > > > >

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2021-03-06 Thread Boqun Feng
On Sat, Mar 06, 2021 at 09:39:54PM +0100, Marc Kleine-Budde wrote: > Hello *, > > On 02.11.2020 11:41:52, Andrea Righi wrote: > > We have the following potential deadlock condition: > > > > > > WARNING: possible irq lock inversion

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2021-03-06 Thread Marc Kleine-Budde
Hello *, On 02.11.2020 11:41:52, Andrea Righi wrote: > We have the following potential deadlock condition: > > > WARNING: possible irq lock inversion dependency detected > 5.10.0-rc2+ #25 Not tainted >

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2020-11-25 Thread Andrea Righi
On Wed, Nov 25, 2020 at 03:15:18PM +0100, Andrea Righi wrote: ... > > I'd hate to see this in stable 3 days after Linus merges it... > > > > Do these need _irqsave, too? > > > > drivers/leds/led-triggers.c: read_lock(>leddev_list_lock); > > drivers/leds/led-triggers.c:

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2020-11-25 Thread Andrea Righi
Hi Pavel, On Wed, Nov 25, 2020 at 01:46:48PM +0100, Pavel Machek wrote: > Hi! > > > We have the following potential deadlock condition: > > > > > > WARNING: possible irq lock inversion dependency detected > > 5.10.0-rc2+ #25 Not

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2020-11-25 Thread Boqun Feng
On Wed, Nov 25, 2020 at 01:46:48PM +0100, Pavel Machek wrote: > Hi! > > > We have the following potential deadlock condition: > > > > > > WARNING: possible irq lock inversion dependency detected > > 5.10.0-rc2+ #25 Not tainted > >

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2020-11-25 Thread Pavel Machek
Hi! > We have the following potential deadlock condition: > > > WARNING: possible irq lock inversion dependency detected > 5.10.0-rc2+ #25 Not tainted > > swapper/3/0 just

[PATCH] leds: trigger: fix potential deadlock with libata

2020-11-02 Thread Andrea Righi
We have the following potential deadlock condition: WARNING: possible irq lock inversion dependency detected 5.10.0-rc2+ #25 Not tainted swapper/3/0 just changed the state of