Re: [PATCH] leds: triggers: add invert to heartbeat

2015-10-08 Thread Jacek Anaszewski
Hi Jiri, On 10/07/2015 04:14 PM, Jiří Prchal wrote: Hi Jacek, comments below... On 7.10.2015 15:32, Jacek Anaszewski wrote: Hi Jiri, Thanks for the patch. It's nice in general, but please see my comments below. On 10/07/2015 11:31 AM, Jiri Prchal wrote: This patcht adds possibility to inver

Re: [PATCH] leds: triggers: add invert to heartbeat

2015-10-07 Thread Jiří Prchal
Hi Jacek, comments below... On 7.10.2015 15:32, Jacek Anaszewski wrote: Hi Jiri, Thanks for the patch. It's nice in general, but please see my comments below. On 10/07/2015 11:31 AM, Jiri Prchal wrote: This patcht adds possibility to invert heartbeat blinking. The inverted LED is more time ON

Re: [PATCH] leds: triggers: add invert to heartbeat

2015-10-07 Thread Jacek Anaszewski
Hi Jiri, Thanks for the patch. It's nice in general, but please see my comments below. On 10/07/2015 11:31 AM, Jiri Prchal wrote: This patcht adds possibility to invert heartbeat blinking. The inverted LED is more time ON then OFF. It's because it looks better when the heartbeat LED is next to

[PATCH] leds: triggers: add invert to heartbeat

2015-10-07 Thread Jiri Prchal
This patcht adds possibility to invert heartbeat blinking. The inverted LED is more time ON then OFF. It's because it looks better when the heartbeat LED is next to other LED which is most time ON. The invert value is exported same way via sysfs in file invert like oneshot. I get inspiration from t