Re: [PATCH] lib/halfmd4: make build optional

2014-11-06 Thread josh
On Thu, Nov 06, 2014 at 04:27:33PM -0500, Aristeu Rozanski wrote: > From: Aristeu Rozanski > > halfmd4 currently is built unconditionally: > textdata bss dec hex filename >801 176 8 985 3d9 lib/halfmd4.o >801 176 8 985 3d9

Re: [PATCH] lib/halfmd4: make build optional

2014-11-06 Thread Kyle McMartin
On Thu, Nov 06, 2014 at 04:27:33PM -0500, Aristeu Rozanski wrote: > +config HALF_MD4 > + bool "Half MD4 transform" > + default y > + help > + This option enables a reduced (32 bit output) version of MD4 > + transform. > + i'd suggest just def_bool n, and not have this promp

Re: [PATCH] lib/halfmd4: make build optional

2014-11-06 Thread Aristeu Rozanski
On Thu, Nov 06, 2014 at 01:32:03PM -0800, Joe Perches wrote: > why not default n ? (and in the other patch) As I see, stuff in lib/ can be available by default unless you specifically ask to disable it. It doesn't really matter in these patches since most of the time the options will be selected i

Re: [PATCH] lib/halfmd4: make build optional

2014-11-06 Thread Joe Perches
On Thu, 2014-11-06 at 16:27 -0500, Aristeu Rozanski wrote: > From: Aristeu Rozanski > > halfmd4 currently is built unconditionally: > textdata bss dec hex filename >801 176 8 985 3d9 lib/halfmd4.o >801 176 8 985 3d9 (TOTALS

[PATCH] lib/halfmd4: make build optional

2014-11-06 Thread Aristeu Rozanski
From: Aristeu Rozanski halfmd4 currently is built unconditionally: textdata bss dec hex filename 801 176 8 985 3d9 lib/halfmd4.o 801 176 8 985 3d9 (TOTALS) and it's used by ext3 and ext4. This patch is useful for situa