Re: [PATCH] lib/hexdump: introduce DUMP_PREFIX_UNHASHED for unhashed addresses

2021-01-16 Thread Timur Tabi
On Fri, Jan 15, 2021 at 3:24 AM Petr Mladek wrote: > By other words, every print_hex_dump() used need to be reviewed in > which context might be called. I did a rough analysis of all current usage of DUMP_PREFIX_ADDRESS in the kernel, compared to the introduction of %px and hashed addresses, usi

Re: [PATCH] lib/hexdump: introduce DUMP_PREFIX_UNHASHED for unhashed addresses

2021-01-15 Thread Petr Mladek
On Thu 2021-01-14 20:56:36, Timur Tabi wrote: > On 1/11/21 7:30 PM, Andrew Morton wrote: > > I doubt if Kees (or I or anyone else) can review this change because > > there are no callers which actually use the new DUMP_PREFIX_UNHASHED. > > Is it intended that some other places in the kernel be chan

Re: [PATCH] lib/hexdump: introduce DUMP_PREFIX_UNHASHED for unhashed addresses

2021-01-14 Thread Timur Tabi
On 1/11/21 7:30 PM, Andrew Morton wrote: I doubt if Kees (or I or anyone else) can review this change because there are no callers which actually use the new DUMP_PREFIX_UNHASHED. Is it intended that some other places in the kernel be changed to use this? If so, please describe where and why, so

Re: [PATCH] lib/hexdump: introduce DUMP_PREFIX_UNHASHED for unhashed addresses

2021-01-11 Thread Andrew Morton
On Mon, 11 Jan 2021 11:10:56 +0100 Petr Mladek wrote: > Adding Kees into CC because it is security related. > Adding Andrew into CC because he usually takes patches for hexdump. > > On Wed 2021-01-06 15:35:47, Timur Tabi wrote: > > Hashed addresses are useless in hexdumps unless you're comparing

Re: [PATCH] lib/hexdump: introduce DUMP_PREFIX_UNHASHED for unhashed addresses

2021-01-11 Thread Petr Mladek
Adding Kees into CC because it is security related. Adding Andrew into CC because he usually takes patches for hexdump. On Wed 2021-01-06 15:35:47, Timur Tabi wrote: > Hashed addresses are useless in hexdumps unless you're comparing > with other hashed addresses, which is unlikely. However, there

[PATCH] lib/hexdump: introduce DUMP_PREFIX_UNHASHED for unhashed addresses

2021-01-06 Thread Timur Tabi
Hashed addresses are useless in hexdumps unless you're comparing with other hashed addresses, which is unlikely. However, there's no need to break existing code, so introduce a new prefix type that prints unhashed addresses. Signed-off-by: Timur Tabi Cc: Roman Fietze --- include/linux/printk.h

[PATCH] lib/hexdump: Make print_hex_dump_bytes() a nop on !DEBUG builds

2019-08-16 Thread Stephen Boyd
I'm seeing a bunch of debug prints from a user of print_hex_dump_bytes() in my kernel logs, but I don't have CONFIG_DYNAMIC_DEBUG enabled nor do I have DEBUG defined in my build. The problem is that print_hex_dump_bytes() calls a wrapper function in lib/hexdump.c that calls print_hex_dump() with K

Re: [PATCH] lib/hexdump

2007-05-03 Thread Randy Dunlap
On Thu, 3 May 2007 09:01:31 +0200 (MEST) Jan Engelhardt wrote: > > On May 2 2007 15:35, Randy Dunlap wrote: > > > >Add hex_dumper() to lib/hexdump.c and linux/kernel.h. > > Right - we've got the second user already, namely the PANIC/OOPS > code print. (The last line, aka "bytes at EIP" under Win

Re: [PATCH] lib/hexdump

2007-05-03 Thread Jan Engelhardt
On May 2 2007 15:35, Randy Dunlap wrote: > >Add hex_dumper() to lib/hexdump.c and linux/kernel.h. Right - we've got the second user already, namely the PANIC/OOPS code print. (The last line, aka "bytes at EIP" under Windows.) Jan 6 14:40:14 deekin kernel: Call Trace: Jan 6 14:40:14 deekin kern

Re: [PATCH] lib/hexdump

2007-05-02 Thread Randy Dunlap
On Wed, 2 May 2007 16:06:35 -0700 Andrew Morton wrote: > On Wed, 02 May 2007 15:56:48 -0700 > Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > Andrew Morton wrote: > > > On Wed, 2 May 2007 15:35:56 -0700 > > > Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > > > >> From: Randy Dunlap <[EMAIL PROTECTED

Re: [PATCH] lib/hexdump

2007-05-02 Thread Andrew Morton
On Wed, 02 May 2007 15:56:48 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Wed, 2 May 2007 15:35:56 -0700 > > Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > >> From: Randy Dunlap <[EMAIL PROTECTED]> > >> > >> Based on ace_dump_mem() from Grant Likely for the Xilinx >

Re: [PATCH] lib/hexdump

2007-05-02 Thread Randy Dunlap
Andrew Morton wrote: On Wed, 2 May 2007 15:35:56 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote: From: Randy Dunlap <[EMAIL PROTECTED]> Based on ace_dump_mem() from Grant Likely for the Xilinx SystemACE CompactFlash interface. Add hex_dumper() to lib/hexdump.c and linux/kernel.h. This patch

Re: [PATCH] lib/hexdump

2007-05-02 Thread Andrew Morton
On Wed, 2 May 2007 15:35:56 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Based on ace_dump_mem() from Grant Likely for the Xilinx > SystemACE CompactFlash interface. > > Add hex_dumper() to lib/hexdump.c and linux/kernel.h. > > This patch adds the

[PATCH] lib/hexdump

2007-05-02 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Based on ace_dump_mem() from Grant Likely for the Xilinx SystemACE CompactFlash interface. Add hex_dumper() to lib/hexdump.c and linux/kernel.h. This patch adds the function 'hex_dumper' which can be used to perform a hex + ASCII dump of data to syslog, i