Re: [PATCH] lib/list-test: add a test for the 'list' doubly linked list

2019-10-08 Thread David Gow
On Mon, Oct 7, 2019 at 6:03 PM Kees Cook wrote: (...) > > + > > +static void list_init_test(struct kunit *test) > > +{ > > + /* Test the different ways of initialising a list. */ > > + struct list_head list1 = LIST_HEAD_INIT(list1); > > + struct list_head list2; > > +

Re: [PATCH] lib/list-test: add a test for the 'list' doubly linked list

2019-10-08 Thread Brendan Higgins
On Tue, Oct 8, 2019 at 11:15 AM Kees Cook wrote: > > On Tue, Oct 08, 2019 at 10:48:37AM -0700, Brendan Higgins wrote: > > On Mon, Oct 07, 2019 at 02:36:33PM -0700, David Gow wrote: > > > This change adds a KUnit test for the kernel doubly linked list > > > implementation in include/linux/list.h >

Re: [PATCH] lib/list-test: add a test for the 'list' doubly linked list

2019-10-08 Thread Kees Cook
On Tue, Oct 08, 2019 at 10:48:37AM -0700, Brendan Higgins wrote: > On Mon, Oct 07, 2019 at 02:36:33PM -0700, David Gow wrote: > > This change adds a KUnit test for the kernel doubly linked list > > implementation in include/linux/list.h > > > > Note that, at present, it only tests the list_ types

Re: [PATCH] lib/list-test: add a test for the 'list' doubly linked list

2019-10-08 Thread Brendan Higgins
On Mon, Oct 07, 2019 at 02:36:33PM -0700, David Gow wrote: > This change adds a KUnit test for the kernel doubly linked list > implementation in include/linux/list.h > > Note that, at present, it only tests the list_ types (not the > singly-linked hlist_), and does not yet test all of the >

Re: [PATCH] lib/list-test: add a test for the 'list' doubly linked list

2019-10-07 Thread Kees Cook
On Mon, Oct 07, 2019 at 02:36:33PM -0700, David Gow wrote: > +config LIST_TEST > + bool "KUnit Test for Kernel Linked-list stuctures" I missed this the first time through: typo of "structures" -- Kees Cook

Re: [PATCH] lib/list-test: add a test for the 'list' doubly linked list

2019-10-07 Thread Kees Cook
On Mon, Oct 07, 2019 at 02:36:33PM -0700, David Gow wrote: > This change adds a KUnit test for the kernel doubly linked list > implementation in include/linux/list.h > > Note that, at present, it only tests the list_ types (not the > singly-linked hlist_), and does not yet test all of the >

Re: [PATCH] lib/list-test: add a test for the 'list' doubly linked list

2019-10-07 Thread Brendan Higgins
On Mon, Oct 07, 2019 at 02:36:33PM -0700, David Gow wrote: > This change adds a KUnit test for the kernel doubly linked list > implementation in include/linux/list.h > > Note that, at present, it only tests the list_ types (not the > singly-linked hlist_), and does not yet test all of the >

[PATCH] lib/list-test: add a test for the 'list' doubly linked list

2019-10-07 Thread David Gow
This change adds a KUnit test for the kernel doubly linked list implementation in include/linux/list.h Note that, at present, it only tests the list_ types (not the singly-linked hlist_), and does not yet test all of the list_for_each_entry* macros (and some related things like