Re: [PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl

2016-04-21 Thread Sowmini Varadhan
On (04/21/16 10:23), Tadeusz Struk wrote: > > What if the mpi_limb_t will happen to be 64 bit? > Thanks, When I checked this with cscope, I found typedef unsigned long int mpi_limb_t; thus I used the *32 functions. But you obviously know better, since you wrote this code (and bug). If you an

Re: [PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl

2016-04-21 Thread Tadeusz Struk
On 04/21/2016 04:07 AM, Sowmini Varadhan wrote: > > Commit 2d4d1eea540b ("lib/mpi: Add mpi sgl helpers") added > mpi_write_to_sgl() which generates traps due to unaligned > access on some platforms like sparc. Fix this by using > the get_unaligned* and put_unaligned* functions. > > Fixes: 2d4d1ee

[PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl

2016-04-21 Thread Sowmini Varadhan
Commit 2d4d1eea540b ("lib/mpi: Add mpi sgl helpers") added mpi_write_to_sgl() which generates traps due to unaligned access on some platforms like sparc. Fix this by using the get_unaligned* and put_unaligned* functions. Fixes: 2d4d1eea540b ("lib/mpi: Add mpi sgl helpers") Signed-off-by: Sowmini