Re: [PATCH] lib/test_kmod: Potential double free in error handling

2019-01-22 Thread Luis Chamberlain
On Mon, Jan 21, 2019 at 05:00:11PM +0300, Dan Carpenter wrote: > There is a copy and paste bug so we set "config->test_driver" to NULL > twice instead of setting "config->test_fs". Smatch complains that it > leads to a double free: > > lib/test_kmod.c:840 __kmod_config_init() warn: 'config->test_

[PATCH] lib/test_kmod: Potential double free in error handling

2019-01-21 Thread Dan Carpenter
There is a copy and paste bug so we set "config->test_driver" to NULL twice instead of setting "config->test_fs". Smatch complains that it leads to a double free: lib/test_kmod.c:840 __kmod_config_init() warn: 'config->test_fs' double freed Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress t