Re: [PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-03 Thread Andy Shevchenko
On Tue, 2016-05-31 at 16:31 -0400, George Spelvin wrote: > From a0d084b1225f2efcf4b5c81871c9c446155b9b13 Mon Sep 17 00:00:00 2001 > From: George Spelvin > Date: Tue, 31 May 2016 16:00:22 -0400 > Subject: [PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays There is a tool called gi

Re: [PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-02 Thread Joe Perches
On Wed, 2016-06-01 at 11:07 -0400, George Spelvin wrote: > On Wed, 01 Jun 2016 at 15:32:47, Andy Shevchenko wrote: > > On Tue, 2016-05-31 at 14:36 -0700, Joe Perches wrote: > > > On Tue, 2016-05-31 at 16:31 -0400, George Spelvin wrote: > > > > -static int __uuid_to_bin(const char *uuid, __u8 b[16],

Re: [PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-01 Thread Andy Shevchenko
On Wed, 2016-06-01 at 12:58 -0700, Andrew Morton wrote: > On 31 May 2016 16:31:22 -0400 "George Spelvin" net> wrote: > > > This patch is on top of the upper/lower case hex optimization for > > lib/vsprintf.c I sent earlier. > > I can't find it.  Please take more care when referring to patches, t

Re: [PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-01 Thread Andrew Morton
On 31 May 2016 16:31:22 -0400 "George Spelvin" wrote: > This patch is on top of the upper/lower case hex optimization for > lib/vsprintf.c I sent earlier. I can't find it. Please take more care when referring to patches, to prevent mistakes from being made.

Re: [PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-01 Thread George Spelvin
On Wed, 01 Jun 2016 at 15:32:47, Andy Shevchenko wrote: > On Tue, 2016-05-31 at 14:36 -0700, Joe Perches wrote: >> On Tue, 2016-05-31 at 16:31 -0400, George Spelvin wrote: >>> -static int __uuid_to_bin(const char *uuid, __u8 b[16], const u8 >>> ei[16]) >>> +static int __uuid_to_bin(const char uuid[

Re: [PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-01 Thread Andy Shevchenko
On Tue, 2016-05-31 at 14:36 -0700, Joe Perches wrote: > On Tue, 2016-05-31 at 16:31 -0400, George Spelvin wrote: > > Here's a patch implementing the suggestion I made earlier.  This > > reduces > > code size, data size, and run time for input and output of UUIDs. > [] > > diff --git a/lib/uuid.c b/

Re: [PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-05-31 Thread George Spelvin
> Functions with sized array arguments are generally undesired. > > Linus once wrote: (http://comments.gmane.org/gmane.linux.kernel/2031400) > > array arguments in C don't >actually exist. Sadly, compilers accept it for various bad historical >reasons, and silently turn it into just a

Re: [PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-05-31 Thread Joe Perches
On Tue, 2016-05-31 at 16:31 -0400, George Spelvin wrote: > Here's a patch implementing the suggestion I made earlier.  This reduces > code size, data size, and run time for input and output of UUIDs. [] > diff --git a/lib/uuid.c b/lib/uuid.c [] > @@ -97,32 +97,28 @@ bool uuid_is_valid(const char *u

[PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-05-31 Thread George Spelvin
>From a0d084b1225f2efcf4b5c81871c9c446155b9b13 Mon Sep 17 00:00:00 2001 From: George Spelvin Date: Tue, 31 May 2016 16:00:22 -0400 Subject: [PATCH] lib/uuid.c: eliminate uuid_[bl]e_index arrays Both input and output code is simplified if we instead use a mapping from binary UUID index to AS