Re: [PATCH] lib: radix: return correct error code on insertion failure

2014-03-01 Thread Johannes Weiner
On Fri, Feb 28, 2014 at 10:54:24PM -0500, Sasha Levin wrote: > We would never check the return value of __radix_tree_create() on insertion > which would cause us to return -EEXIST on all cases of failure, even when > such failure would be running out of memory, for example. > > This would trigger

Re: [PATCH] lib: radix: return correct error code on insertion failure

2014-03-01 Thread Johannes Weiner
On Fri, Feb 28, 2014 at 10:54:24PM -0500, Sasha Levin wrote: We would never check the return value of __radix_tree_create() on insertion which would cause us to return -EEXIST on all cases of failure, even when such failure would be running out of memory, for example. This would trigger

[PATCH] lib: radix: return correct error code on insertion failure

2014-02-28 Thread Sasha Levin
We would never check the return value of __radix_tree_create() on insertion which would cause us to return -EEXIST on all cases of failure, even when such failure would be running out of memory, for example. This would trigger errors in various code that assumed that -EEXIST is a critical

[PATCH] lib: radix: return correct error code on insertion failure

2014-02-28 Thread Sasha Levin
We would never check the return value of __radix_tree_create() on insertion which would cause us to return -EEXIST on all cases of failure, even when such failure would be running out of memory, for example. This would trigger errors in various code that assumed that -EEXIST is a critical