Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-25 Thread Benjamin Herrenschmidt
> Yes. > > Alan loves to complain about lack of MMIO flush, but in practice this is > rarely the source of problems such as the one you describe. > > But if its broken its broken, and we need to revert. Any luck getting > benh access to the device? > Especially since reverting it will

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-25 Thread Guennadi Liakhovetski
On Mon, 25 Feb 2008, Jeff Garzik wrote: > But if its broken its broken, and we need to revert. Any luck getting benh > access to the device? We're working on it... We've got devices, but they have to be recovered with jtag first, which requires some soldering... I was told this should happen

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-25 Thread Jeff Garzik
Tim Ellis wrote: On 15 Feb 2008, at 21:45, Benjamin Herrenschmidt wrote: On Fri, 2008-02-15 at 15:53 +, Alan Cox wrote: That's strange though. Somebody with knowledge of that HW (or specs) who can spot something ? Could it be an issue with timing ? I don't have HW access to this

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-25 Thread Jeff Garzik
Tim Ellis wrote: On 15 Feb 2008, at 21:45, Benjamin Herrenschmidt wrote: On Fri, 2008-02-15 at 15:53 +, Alan Cox wrote: That's strange though. Somebody with knowledge of that HW (or specs) who can spot something ? Could it be an issue with timing ? I don't have HW access to this

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-25 Thread Guennadi Liakhovetski
On Mon, 25 Feb 2008, Jeff Garzik wrote: But if its broken its broken, and we need to revert. Any luck getting benh access to the device? We're working on it... We've got devices, but they have to be recovered with jtag first, which requires some soldering... I was told this should happen

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-25 Thread Benjamin Herrenschmidt
Yes. Alan loves to complain about lack of MMIO flush, but in practice this is rarely the source of problems such as the one you describe. But if its broken its broken, and we need to revert. Any luck getting benh access to the device? Especially since reverting it will break a

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Tim Ellis
On 15 Feb 2008, at 21:45, Benjamin Herrenschmidt wrote: On Fri, 2008-02-15 at 15:53 +, Alan Cox wrote: That's strange though. Somebody with knowledge of that HW (or specs) who can spot something ? Could it be an issue with timing ? I don't have HW access to this machine. If somebody

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Benjamin Herrenschmidt
On Fri, 2008-02-15 at 22:27 +, Alan Cox wrote: > > The dbdma start is mostly harmless (things don't get posted for -that- > > long), though I suppose it's worth fixing. Would reading back dmactl do > > in that case or do you foresee any kind of side effect ? (Maybe only > > doing it for MMIO

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Alan Cox
> The dbdma start is mostly harmless (things don't get posted for -that- > long), though I suppose it's worth fixing. Would reading back dmactl do > in that case or do you foresee any kind of side effect ? (Maybe only > doing it for MMIO ?) The dmactl read back should be just fine, or any other

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Benjamin Herrenschmidt
On Fri, 2008-02-15 at 15:53 +, Alan Cox wrote: > > > That's strange though. Somebody with knowledge of that HW (or specs) who > > > can spot something ? Could it be an issue with timing ? > > > > > > I don't have HW access to this machine. If somebody could send one to me > > > I could do

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Benjamin Herrenschmidt
> Ben, would an ssh access to such a machine and to a terminal server > suffice? If I can remote-reboot it, yes. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Alan Cox
> > That's strange though. Somebody with knowledge of that HW (or specs) who > > can spot something ? Could it be an issue with timing ? > > > > I don't have HW access to this machine. If somebody could send one to me > > I could do more investigation. > > Ben, would an ssh access to such a

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Guennadi Liakhovetski
On Wed, 13 Feb 2008, Benjamin Herrenschmidt wrote: > On Tue, 2008-02-12 at 15:58 +, Tim Ellis wrote: > > > This change causes attached drives to no longer be detected and > > function on the PowerPC Buffalo Linkstation machines: > > > > <7>pata_sil680 :00:0c.0: version 0.4.8 > >

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Alan Cox
That's strange though. Somebody with knowledge of that HW (or specs) who can spot something ? Could it be an issue with timing ? I don't have HW access to this machine. If somebody could send one to me I could do more investigation. Ben, would an ssh access to such a machine and to a

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Guennadi Liakhovetski
On Wed, 13 Feb 2008, Benjamin Herrenschmidt wrote: On Tue, 2008-02-12 at 15:58 +, Tim Ellis wrote: This change causes attached drives to no longer be detected and function on the PowerPC Buffalo Linkstation machines: 7pata_sil680 :00:0c.0: version 0.4.8 6sil680: 133MHz

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Benjamin Herrenschmidt
On Fri, 2008-02-15 at 15:53 +, Alan Cox wrote: That's strange though. Somebody with knowledge of that HW (or specs) who can spot something ? Could it be an issue with timing ? I don't have HW access to this machine. If somebody could send one to me I could do more

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Benjamin Herrenschmidt
Ben, would an ssh access to such a machine and to a terminal server suffice? If I can remote-reboot it, yes. Cheers, Ben. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Benjamin Herrenschmidt
On Fri, 2008-02-15 at 22:27 +, Alan Cox wrote: The dbdma start is mostly harmless (things don't get posted for -that- long), though I suppose it's worth fixing. Would reading back dmactl do in that case or do you foresee any kind of side effect ? (Maybe only doing it for MMIO ?)

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Alan Cox
The dbdma start is mostly harmless (things don't get posted for -that- long), though I suppose it's worth fixing. Would reading back dmactl do in that case or do you foresee any kind of side effect ? (Maybe only doing it for MMIO ?) The dmactl read back should be just fine, or any other DMA

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Tim Ellis
On 15 Feb 2008, at 21:45, Benjamin Herrenschmidt wrote: On Fri, 2008-02-15 at 15:53 +, Alan Cox wrote: That's strange though. Somebody with knowledge of that HW (or specs) who can spot something ? Could it be an issue with timing ? I don't have HW access to this machine. If somebody

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-12 Thread Alan Cox
> That's strange though. Somebody with knowledge of that HW (or specs) who > can spot something ? Could it be an issue with timing ? > > I don't have HW access to this machine. If somebody could send one to me > I could do more investigation. Did anyone fix all the mmio posting bugs in

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-12 Thread Benjamin Herrenschmidt
On Tue, 2008-02-12 at 15:58 +, Tim Ellis wrote: > This change causes attached drives to no longer be detected and > function on the PowerPC Buffalo Linkstation machines: > > <7>pata_sil680 :00:0c.0: version 0.4.8 > <6>sil680: 133MHz clock. > <6>scsi0 : pata_sil680 > <6>scsi1 :

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-12 Thread Tim Ellis
Hi, This change causes attached drives to no longer be detected and function on the PowerPC Buffalo Linkstation machines: <7>pata_sil680 :00:0c.0: version 0.4.8 <6>sil680: 133MHz clock. <6>scsi0 : pata_sil680 <6>scsi1 : pata_sil680 <6>ata1: PATA max UDMA/133 irq 18 <6>ata2: PATA max

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-12 Thread Alan Cox
That's strange though. Somebody with knowledge of that HW (or specs) who can spot something ? Could it be an issue with timing ? I don't have HW access to this machine. If somebody could send one to me I could do more investigation. Did anyone fix all the mmio posting bugs in libata-core

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-12 Thread Tim Ellis
Hi, This change causes attached drives to no longer be detected and function on the PowerPC Buffalo Linkstation machines: 7pata_sil680 :00:0c.0: version 0.4.8 6sil680: 133MHz clock. 6scsi0 : pata_sil680 6scsi1 : pata_sil680 6ata1: PATA max UDMA/133 irq 18 6ata2: PATA max UDMA/133 irq 18