Re: [PATCH] libata: don't whine if ->prereset() returns -ENOENT

2007-03-19 Thread Jeff Garzik
Tejun Heo wrote: ->prereset() returns -ENOENT to tell libata that the port is empty and reset sequencing should be stopped. This is not an error condition. Update ata_eh_reset() such that it sets device classes to ATA_DEV_NONE and return success in on -ENOENT. This makes spurious error message

Re: [PATCH] libata: don't whine if -prereset() returns -ENOENT

2007-03-19 Thread Jeff Garzik
Tejun Heo wrote: -prereset() returns -ENOENT to tell libata that the port is empty and reset sequencing should be stopped. This is not an error condition. Update ata_eh_reset() such that it sets device classes to ATA_DEV_NONE and return success in on -ENOENT. This makes spurious error message

Re: [PATCH] libata: don't whine if ->prereset() returns -ENOENT

2007-03-12 Thread Fabio Comolli
Applied on top of latest GIT this patch make the warning[1] disappear. Thanks, Fabio [1] ata2: reset failed, giving up On 3/12/07, Tejun Heo <[EMAIL PROTECTED]> wrote: ->prereset() returns -ENOENT to tell libata that the port is empty and reset sequencing should be stopped. This is not an

Re: [PATCH] libata: don't whine if ->prereset() returns -ENOENT

2007-03-12 Thread Alan Cox
> 1. I think these ports should be made dummy instead of returning > -ENOENT on prereset(). -ENOENT from prereset() was a hack to keep > ata_piix's behavior unchanged while converting it to new EH. If no > one objcts, I'll convert similar usages to use dummy ports after new > init model and drop

[PATCH] libata: don't whine if ->prereset() returns -ENOENT

2007-03-12 Thread Tejun Heo
->prereset() returns -ENOENT to tell libata that the port is empty and reset sequencing should be stopped. This is not an error condition. Update ata_eh_reset() such that it sets device classes to ATA_DEV_NONE and return success in on -ENOENT. This makes spurious error message go away.

[PATCH] libata: don't whine if -prereset() returns -ENOENT

2007-03-12 Thread Tejun Heo
-prereset() returns -ENOENT to tell libata that the port is empty and reset sequencing should be stopped. This is not an error condition. Update ata_eh_reset() such that it sets device classes to ATA_DEV_NONE and return success in on -ENOENT. This makes spurious error message go away.

Re: [PATCH] libata: don't whine if -prereset() returns -ENOENT

2007-03-12 Thread Alan Cox
1. I think these ports should be made dummy instead of returning -ENOENT on prereset(). -ENOENT from prereset() was a hack to keep ata_piix's behavior unchanged while converting it to new EH. If no one objcts, I'll convert similar usages to use dummy ports after new init model and drop

Re: [PATCH] libata: don't whine if -prereset() returns -ENOENT

2007-03-12 Thread Fabio Comolli
Applied on top of latest GIT this patch make the warning[1] disappear. Thanks, Fabio [1] ata2: reset failed, giving up On 3/12/07, Tejun Heo [EMAIL PROTECTED] wrote: -prereset() returns -ENOENT to tell libata that the port is empty and reset sequencing should be stopped. This is not an error