Re: [PATCH] libata: fix shutdown warning message printing

2007-05-15 Thread Jeff Garzik
Tejun Heo wrote: Unlocking ap->lock and ssleeping don't work because SCSI commands can be issued from completion path without context. Reimplement delayed completion by allowing translation functions to override qc->scsidone(), storing the original completion function to scmd->scsi_done() and ov

Re: [PATCH] libata: fix shutdown warning message printing

2007-05-14 Thread James Bottomley
On Mon, 2007-05-14 at 17:26 +0200, Tejun Heo wrote: > Unlocking ap->lock and ssleeping don't work because SCSI commands can > be issued from completion path without context. Reimplement delayed > completion by allowing translation functions to override > qc->scsidone(), storing the original comple

[PATCH] libata: fix shutdown warning message printing

2007-05-14 Thread Tejun Heo
Unlocking ap->lock and ssleeping don't work because SCSI commands can be issued from completion path without context. Reimplement delayed completion by allowing translation functions to override qc->scsidone(), storing the original completion function to scmd->scsi_done() and overriding qc->scsido