Re: [PATCH] libata: revert "libata: use blk taging" et al.

2015-03-12 Thread Shaohua Li
On Thu, Mar 12, 2015 at 09:59:26AM -0400, Tejun Heo wrote: > On Thu, Mar 12, 2015 at 05:46:01AM -0700, Shaohua Li wrote: > > ata: Add a new flag for sas controller > > > > Add a new flag to destinguish sas controller. sas controller has its own tag > > allocation, which doesn't directly match to a

Re: [PATCH] libata: revert "libata: use blk taging" et al.

2015-03-12 Thread Tejun Heo
On Thu, Mar 12, 2015 at 05:46:01AM -0700, Shaohua Li wrote: > ata: Add a new flag for sas controller > > Add a new flag to destinguish sas controller. sas controller has its own tag > allocation, which doesn't directly match to ata tag. We use the new flag for > sas ata tag allocation. This doesn

Re: [PATCH] libata: revert "libata: use blk taging" et al.

2015-03-12 Thread Tony Battersby
On 03/12/2015 08:46 AM, Shaohua Li wrote: > Yep. Tony, can you please try below patch please? > > > ata: Add a new flag for sas controller > > Add a new flag to destinguish sas controller. sas controller has its own tag > allocation, which doesn't directly match to ata tag. We use the new flag for

Re: [PATCH] libata: revert "libata: use blk taging" et al.

2015-03-12 Thread Shaohua Li
On Thu, Mar 12, 2015 at 08:11:57AM -0400, Tejun Heo wrote: > On Thu, Mar 12, 2015 at 06:14:24AM -0400, Dan Williams wrote: > > > @@ -572,7 +572,6 @@ int sas_ata_init(struct domain_device *found_dev) > > > > > > ap->private_data = found_dev; > > > ap->cbl = ATA_CBL_SATA; > > > -

Re: [PATCH] libata: revert "libata: use blk taging" et al.

2015-03-12 Thread Tejun Heo
On Thu, Mar 12, 2015 at 06:14:24AM -0400, Dan Williams wrote: > > @@ -572,7 +572,6 @@ int sas_ata_init(struct domain_device *found_dev) > > > > ap->private_data = found_dev; > > ap->cbl = ATA_CBL_SATA; > > - ap->scsi_host = shost; > > rc = ata_sas_port_init(ap); > >

Re: [PATCH] libata: revert "libata: use blk taging" et al.

2015-03-12 Thread Dan Williams
On Wed, Mar 11, 2015 at 10:31 PM, Shaohua Li wrote: > On Wed, Mar 11, 2015 at 06:19:27PM -0400, Tony Battersby wrote: >> On 03/11/2015 05:45 PM, Jens Axboe wrote: >> > On 03/11/2015 02:15 PM, Tony Battersby wrote: >> >> This reverts commits 12cb5ce101abfaf74421f8cc9f196e708209eb79 and >> >> 98bd4b

Re: [PATCH] libata: revert "libata: use blk taging" et al.

2015-03-11 Thread Shaohua Li
On Wed, Mar 11, 2015 at 06:19:27PM -0400, Tony Battersby wrote: > On 03/11/2015 05:45 PM, Jens Axboe wrote: > > On 03/11/2015 02:15 PM, Tony Battersby wrote: > >> This reverts commits 12cb5ce101abfaf74421f8cc9f196e708209eb79 and > >> 98bd4be1ba95f2fe7f543910792b7163a5de06eb. > >> > >> Commit 12cb5c

Re: [PATCH] libata: revert "libata: use blk taging" et al.

2015-03-11 Thread Shaohua Li
On Wed, Mar 11, 2015 at 06:19:27PM -0400, Tony Battersby wrote: > On 03/11/2015 05:45 PM, Jens Axboe wrote: > > On 03/11/2015 02:15 PM, Tony Battersby wrote: > >> This reverts commits 12cb5ce101abfaf74421f8cc9f196e708209eb79 and > >> 98bd4be1ba95f2fe7f543910792b7163a5de06eb. > >> > >> Commit 12cb5c

Re: [PATCH] libata: revert "libata: use blk taging" et al.

2015-03-11 Thread Tony Battersby
On 03/11/2015 05:45 PM, Jens Axboe wrote: > On 03/11/2015 02:15 PM, Tony Battersby wrote: >> This reverts commits 12cb5ce101abfaf74421f8cc9f196e708209eb79 and >> 98bd4be1ba95f2fe7f543910792b7163a5de06eb. >> >> Commit 12cb5ce101ab ("libata: use blk taging") causes the following oops >> with scsi-mq

Re: [PATCH] libata: revert "libata: use blk taging" et al.

2015-03-11 Thread Jens Axboe
On 03/11/2015 02:15 PM, Tony Battersby wrote: This reverts commits 12cb5ce101abfaf74421f8cc9f196e708209eb79 and 98bd4be1ba95f2fe7f543910792b7163a5de06eb. Commit 12cb5ce101ab ("libata: use blk taging") causes the following oops with scsi-mq enabled: BUG: unable to handle kernel NULL pointer dere

[PATCH] libata: revert "libata: use blk taging" et al.

2015-03-11 Thread Tony Battersby
This reverts commits 12cb5ce101abfaf74421f8cc9f196e708209eb79 and 98bd4be1ba95f2fe7f543910792b7163a5de06eb. Commit 12cb5ce101ab ("libata: use blk taging") causes the following oops with scsi-mq enabled: BUG: unable to handle kernel NULL pointer dereference at 0058 IP: [] ata_qc_new_in