Re: [PATCH] libata ATAPI transfer size cleanups

2007-11-01 Thread Jeff Garzik
Torsten Kaiser wrote: On 11/1/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: + lo = tf->lbam; + hi = tf->lbam; + ibyte = (hi << 8) | lo; + + lo = result_tf->lbam; + hi = result_tf->lbam; That doesn't look right. I suspect this was intended: lo = tf->lbam; hi = tf->lb

Re: [PATCH] libata ATAPI transfer size cleanups

2007-11-01 Thread Torsten Kaiser
On 11/1/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > + lo = tf->lbam; > + hi = tf->lbam; > + ibyte = (hi << 8) | lo; > + > + lo = result_tf->lbam; > + hi = result_tf->lbam; That doesn't look right. I suspect this was intended: lo = tf->lbam; hi = tf->lbah; Torsten -

Re: [PATCH] libata ATAPI transfer size cleanups

2007-11-01 Thread Alan Cox
On Thu, 01 Nov 2007 05:54:06 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > > On Thu, 1 Nov 2007 05:07:33 -0400 > > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >> This is purely for comment and testing, not for merging (yet?). > >> > >> A common recipe in several vendor drivers

Re: [PATCH] libata ATAPI transfer size cleanups

2007-11-01 Thread Jeff Garzik
Alan Cox wrote: On Thu, 1 Nov 2007 05:07:33 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: This is purely for comment and testing, not for merging (yet?). A common recipe in several vendor drivers (either GPL'd, or I have NDA'd access to use them as a documentation-like reference) for ATAPI was

Re: [PATCH] libata ATAPI transfer size cleanups

2007-11-01 Thread Alan Cox
On Thu, 1 Nov 2007 05:07:33 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > > This is purely for comment and testing, not for merging (yet?). > > A common recipe in several vendor drivers (either GPL'd, or I have NDA'd > access to use them as a documentation-like reference) for ATAPI was > slight

[PATCH] libata ATAPI transfer size cleanups

2007-11-01 Thread Jeff Garzik
This is purely for comment and testing, not for merging (yet?). A common recipe in several vendor drivers (either GPL'd, or I have NDA'd access to use them as a documentation-like reference) for ATAPI was slightly different from ours. This recipe can be found in atapi_tf_xfer_size(), and it's sl