Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Matias Bjørling
On 03/05/2018 03:18 PM, Javier González wrote: On 5 Mar 2018, at 15.16, Matias Bjørling wrote: On 03/05/2018 02:45 PM, Javier González wrote: On 5 Mar 2018, at 14.38, Matias Bjørling wrote: On 03/01/2018 08:29 PM, Javier González wrote: On 1 Mar 2018, at

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Matias Bjørling
On 03/05/2018 03:18 PM, Javier González wrote: On 5 Mar 2018, at 15.16, Matias Bjørling wrote: On 03/05/2018 02:45 PM, Javier González wrote: On 5 Mar 2018, at 14.38, Matias Bjørling wrote: On 03/01/2018 08:29 PM, Javier González wrote: On 1 Mar 2018, at 19.49, Matias Bjørling wrote: On

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Javier González
> On 5 Mar 2018, at 15.16, Matias Bjørling wrote: > > On 03/05/2018 02:45 PM, Javier González wrote: >>> On 5 Mar 2018, at 14.38, Matias Bjørling wrote: >>> >>> On 03/01/2018 08:29 PM, Javier González wrote: > On 1 Mar 2018, at 19.49, Matias Bjørling

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Javier González
> On 5 Mar 2018, at 15.16, Matias Bjørling wrote: > > On 03/05/2018 02:45 PM, Javier González wrote: >>> On 5 Mar 2018, at 14.38, Matias Bjørling wrote: >>> >>> On 03/01/2018 08:29 PM, Javier González wrote: > On 1 Mar 2018, at 19.49, Matias Bjørling wrote: > > On 03/01/2018

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Matias Bjørling
On 03/05/2018 02:45 PM, Javier González wrote: On 5 Mar 2018, at 14.38, Matias Bjørling wrote: On 03/01/2018 08:29 PM, Javier González wrote: On 1 Mar 2018, at 19.49, Matias Bjørling wrote: On 03/01/2018 04:59 PM, Javier González wrote: Refactor init and

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Matias Bjørling
On 03/05/2018 02:45 PM, Javier González wrote: On 5 Mar 2018, at 14.38, Matias Bjørling wrote: On 03/01/2018 08:29 PM, Javier González wrote: On 1 Mar 2018, at 19.49, Matias Bjørling wrote: On 03/01/2018 04:59 PM, Javier González wrote: Refactor init and exit sequences to eliminate

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Javier González
> On 5 Mar 2018, at 14.38, Matias Bjørling wrote: > > On 03/01/2018 08:29 PM, Javier González wrote: >>> On 1 Mar 2018, at 19.49, Matias Bjørling wrote: >>> >>> On 03/01/2018 04:59 PM, Javier González wrote: Refactor init and exit sequences to eliminate

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Javier González
> On 5 Mar 2018, at 14.38, Matias Bjørling wrote: > > On 03/01/2018 08:29 PM, Javier González wrote: >>> On 1 Mar 2018, at 19.49, Matias Bjørling wrote: >>> >>> On 03/01/2018 04:59 PM, Javier González wrote: Refactor init and exit sequences to eliminate dependencies among init

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Matias Bjørling
On 03/01/2018 08:29 PM, Javier González wrote: On 1 Mar 2018, at 19.49, Matias Bjørling wrote: On 03/01/2018 04:59 PM, Javier González wrote: Refactor init and exit sequences to eliminate dependencies among init modules and improve readability. Signed-off-by: Javier

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Matias Bjørling
On 03/01/2018 08:29 PM, Javier González wrote: On 1 Mar 2018, at 19.49, Matias Bjørling wrote: On 03/01/2018 04:59 PM, Javier González wrote: Refactor init and exit sequences to eliminate dependencies among init modules and improve readability. Signed-off-by: Javier González ---

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-01 Thread Javier González
> On 1 Mar 2018, at 19.49, Matias Bjørling wrote: > > On 03/01/2018 04:59 PM, Javier González wrote: >> Refactor init and exit sequences to eliminate dependencies among init >> modules and improve readability. >> Signed-off-by: Javier González >> --- >>

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-01 Thread Javier González
> On 1 Mar 2018, at 19.49, Matias Bjørling wrote: > > On 03/01/2018 04:59 PM, Javier González wrote: >> Refactor init and exit sequences to eliminate dependencies among init >> modules and improve readability. >> Signed-off-by: Javier González >> --- >> drivers/lightnvm/pblk-init.c | 415 >>

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-01 Thread Matias Bjørling
On 03/01/2018 04:59 PM, Javier González wrote: Refactor init and exit sequences to eliminate dependencies among init modules and improve readability. Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 415 +-- 1

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-01 Thread Matias Bjørling
On 03/01/2018 04:59 PM, Javier González wrote: Refactor init and exit sequences to eliminate dependencies among init modules and improve readability. Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 415 +-- 1 file changed, 206

[PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-01 Thread Javier González
Refactor init and exit sequences to eliminate dependencies among init modules and improve readability. Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 415 +-- 1 file changed, 206 insertions(+), 209 deletions(-)

[PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-01 Thread Javier González
Refactor init and exit sequences to eliminate dependencies among init modules and improve readability. Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 415 +-- 1 file changed, 206 insertions(+), 209 deletions(-) diff --git

[PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-01 Thread Javier González
Refactor init and exit sequences to eliminate dependencies among init modules and improve readability. Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 412 +-- 1 file changed, 206 insertions(+), 206 deletions(-)

[PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-01 Thread Javier González
Refactor init and exit sequences to eliminate dependencies among init modules and improve readability. Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 412 +-- 1 file changed, 206 insertions(+), 206 deletions(-) diff --git

[PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-01 Thread Javier González
The init/exit sequences have grown in a very bad way. Refactor them to eliminate dependencies across initialization modules. One of these dependencies caused a bad double free when introducing a preparation patch for 2.0 bad block identification. This was reported by Dan Carpenter and 0-DAY.

[PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-01 Thread Javier González
The init/exit sequences have grown in a very bad way. Refactor them to eliminate dependencies across initialization modules. One of these dependencies caused a bad double free when introducing a preparation patch for 2.0 bad block identification. This was reported by Dan Carpenter and 0-DAY.