Re: [PATCH] ligtnvm: fix double blk_put_queue on same queue

2017-04-20 Thread Jens Axboe
On Thu, Apr 20 2017, Matias Bjørling wrote: > On 04/20/2017 04:09 PM, Jens Axboe wrote: > >On Thu, Apr 20 2017, Matias Bjørling wrote: > >>On 04/19/2017 11:47 PM, Rakesh Pandit wrote: > >>>On an error path in NVM_DEV_CREATE ioctl blk_put_queue is being called > >>>twice: one via blk_cleanup_queue a

Re: [PATCH] ligtnvm: fix double blk_put_queue on same queue

2017-04-20 Thread Matias Bjørling
On 04/20/2017 04:09 PM, Jens Axboe wrote: On Thu, Apr 20 2017, Matias Bjørling wrote: On 04/19/2017 11:47 PM, Rakesh Pandit wrote: On an error path in NVM_DEV_CREATE ioctl blk_put_queue is being called twice: one via blk_cleanup_queue and another via put_disk. Straight fix seems to remove queu

Re: [PATCH] ligtnvm: fix double blk_put_queue on same queue

2017-04-20 Thread Jens Axboe
On Thu, Apr 20 2017, Matias Bjørling wrote: > On 04/19/2017 11:47 PM, Rakesh Pandit wrote: > >On an error path in NVM_DEV_CREATE ioctl blk_put_queue is being called > >twice: one via blk_cleanup_queue and another via put_disk. Straight fix > >seems to remove queue pointer so that disk_release neve

Re: [PATCH] ligtnvm: fix double blk_put_queue on same queue

2017-04-20 Thread Matias Bjørling
On 04/19/2017 11:47 PM, Rakesh Pandit wrote: On an error path in NVM_DEV_CREATE ioctl blk_put_queue is being called twice: one via blk_cleanup_queue and another via put_disk. Straight fix seems to remove queue pointer so that disk_release never ends up caling blk_put_queue again. [ 391.80882

[PATCH] ligtnvm: fix double blk_put_queue on same queue

2017-04-19 Thread Rakesh Pandit
On an error path in NVM_DEV_CREATE ioctl blk_put_queue is being called twice: one via blk_cleanup_queue and another via put_disk. Straight fix seems to remove queue pointer so that disk_release never ends up caling blk_put_queue again. [ 391.808827] WARNING: CPU: 1 PID: 1250 at lib/refcount.c: