Re: [PATCH] livepatch: Cancel transition a safe way for immediate patches

2017-04-11 Thread Jiri Kosina
On Tue, 11 Apr 2017, Petr Mladek wrote: > klp_init_transition() does not set func->transition for immediate patches. > Then klp_ftrace_handler() could use the new code immediately. As a result, > it is not safe to put the livepatch module in klp_cancel_transition(). > > This patch reverts most of

Re: [PATCH] livepatch: Cancel transition a safe way for immediate patches

2017-04-11 Thread Josh Poimboeuf
On Tue, Apr 11, 2017 at 01:07:48PM +0200, Petr Mladek wrote: > klp_init_transition() does not set func->transition for immediate patches. > Then klp_ftrace_handler() could use the new code immediately. As a result, > it is not safe to put the livepatch module in klp_cancel_transition(). > > This p

Re: [PATCH] livepatch: Cancel transition a safe way for immediate patches

2017-04-11 Thread Miroslav Benes
On Tue, 11 Apr 2017, Petr Mladek wrote: > klp_init_transition() does not set func->transition for immediate patches. > Then klp_ftrace_handler() could use the new code immediately. As a result, > it is not safe to put the livepatch module in klp_cancel_transition(). > > This patch reverts most of

[PATCH] livepatch: Cancel transition a safe way for immediate patches

2017-04-11 Thread Petr Mladek
klp_init_transition() does not set func->transition for immediate patches. Then klp_ftrace_handler() could use the new code immediately. As a result, it is not safe to put the livepatch module in klp_cancel_transition(). This patch reverts most of the last minute changes klp_cancel_transition(). I