Re: [PATCH] livepatch: Enforce reliable stack trace as config dependency

2019-04-16 Thread Miroslav Benes
On Tue, 16 Apr 2019, Josh Poimboeuf wrote: > On Tue, Apr 16, 2019 at 01:47:30PM +0200, Jiri Kosina wrote: > > On Tue, 12 Feb 2019, Petr Mladek wrote: > > > > > > I think I'd rather go in the opposite direction: allow the patches to be > > > > loaded. Then they can be forced, if needed. That

Re: [PATCH] livepatch: Enforce reliable stack trace as config dependency

2019-04-16 Thread Josh Poimboeuf
On Tue, Apr 16, 2019 at 01:47:30PM +0200, Jiri Kosina wrote: > On Tue, 12 Feb 2019, Petr Mladek wrote: > > > > I think I'd rather go in the opposite direction: allow the patches to be > > > loaded. Then they can be forced, if needed. That enables both compile > > > and runtime testing. That

Re: [PATCH] livepatch: Enforce reliable stack trace as config dependency

2019-04-16 Thread Jiri Kosina
On Tue, 16 Apr 2019, Jiri Kosina wrote: > > Do you mean to convert the error into warning? > > > > For example, the change below. Note that I did not mention > > the possibility to force the transition by intention. It is risky > > and people should not get used to it. > > > > Heh, I think that

Re: [PATCH] livepatch: Enforce reliable stack trace as config dependency

2019-04-16 Thread Jiri Kosina
On Tue, 12 Feb 2019, Petr Mladek wrote: > > I think I'd rather go in the opposite direction: allow the patches to be > > loaded. Then they can be forced, if needed. That enables both compile > > and runtime testing. That way we don't make any backward progress, > > until such arches get

Re: [PATCH] livepatch: Enforce reliable stack trace as config dependency

2019-02-12 Thread Petr Mladek
On Mon 2019-02-11 08:08:13, Josh Poimboeuf wrote: > Anyway, I'm not sure about this approach. This patch makes the s390 > livepatch code no longer compilable, turning it into completely dead > code. So if something changes in the s390 code which causes it to stop > compiling, nobody will notice.

Re: [PATCH] livepatch: Enforce reliable stack trace as config dependency

2019-02-11 Thread Kamalesh Babulal
On Mon, Feb 11, 2019 at 08:08:13AM -0600, Josh Poimboeuf wrote: > On Sat, Feb 09, 2019 at 02:47:28PM +0530, Kamalesh Babulal wrote: > > After removal of the immediate flag by commit d0807da78e11 > > ("livepatch: Remove immediate feature"), reliable stack trace became > > enforcing dependency for

Re: [PATCH] livepatch: Enforce reliable stack trace as config dependency

2019-02-11 Thread Josh Poimboeuf
On Sat, Feb 09, 2019 at 02:47:28PM +0530, Kamalesh Babulal wrote: > While the consistency model was introduced, architectures without the > reliable stack trace implementation could use the immediate flag for > livepatching but with its own limitations. > > After removal of the immediate flag by

Re: [PATCH] livepatch: Enforce reliable stack trace as config dependency

2019-02-11 Thread Petr Mladek
On Sat 2019-02-09 14:47:28, Kamalesh Babulal wrote: > While the consistency model was introduced, architectures without the > reliable stack trace implementation could use the immediate flag for > livepatching but with its own limitations. > > After removal of the immediate flag by commit

[PATCH] livepatch: Enforce reliable stack trace as config dependency

2019-02-09 Thread Kamalesh Babulal
While the consistency model was introduced, architectures without the reliable stack trace implementation could use the immediate flag for livepatching but with its own limitations. After removal of the immediate flag by commit d0807da78e11 ("livepatch: Remove immediate feature"), reliable stack