Re: [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD

2021-03-26 Thread Miroslav Benes
On Thu, 25 Mar 2021, Jens Axboe wrote: > On 3/25/21 3:30 AM, Miroslav Benes wrote: > >> (PF_KTHREAD | PF_IO_WORKER) is open coded in soo many places maybe this is > >> a > >> silly question, but... > >> > >> If the livepatch code could use fake_signal_wake_up(), we could consolidate > >> the patt

Re: [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD

2021-03-25 Thread dongkai (H)
On 2021/3/25 17:26, Miroslav Benes wrote: On Thu, 25 Mar 2021, Dong Kai wrote: commit 15b2219facad ("kernel: freezer should treat PF_IO_WORKER like PF_KTHREAD for freezing") is to fix the freezeing issue of IO threads by making the freezer not send them fake signals. Here live patching consist

Re: [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD

2021-03-25 Thread Joe Lawrence
On 3/25/21 5:26 AM, Miroslav Benes wrote: On Thu, 25 Mar 2021, Dong Kai wrote: commit 15b2219facad ("kernel: freezer should treat PF_IO_WORKER like PF_KTHREAD for freezing") is to fix the freezeing issue of IO threads by making the freezer not send them fake signals. Here live patching consist

Re: [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD

2021-03-25 Thread Jens Axboe
On 3/25/21 3:30 AM, Miroslav Benes wrote: >> (PF_KTHREAD | PF_IO_WORKER) is open coded in soo many places maybe this is a >> silly question, but... >> >> If the livepatch code could use fake_signal_wake_up(), we could consolidate >> the pattern in klp_send_signals() with the one in freeze_task().

Re: [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD

2021-03-25 Thread Jens Axboe
On 3/24/21 7:48 PM, Dong Kai wrote: > commit 15b2219facad ("kernel: freezer should treat PF_IO_WORKER like > PF_KTHREAD for freezing") is to fix the freezeing issue of IO threads > by making the freezer not send them fake signals. > > Here live patching consistency model call klp_send_signals to w

Re: [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD

2021-03-25 Thread Miroslav Benes
> (PF_KTHREAD | PF_IO_WORKER) is open coded in soo many places maybe this is a > silly question, but... > > If the livepatch code could use fake_signal_wake_up(), we could consolidate > the pattern in klp_send_signals() with the one in freeze_task(). Then there > would only one place for wake up

Re: [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD

2021-03-25 Thread Miroslav Benes
On Thu, 25 Mar 2021, Dong Kai wrote: > commit 15b2219facad ("kernel: freezer should treat PF_IO_WORKER like > PF_KTHREAD for freezing") is to fix the freezeing issue of IO threads > by making the freezer not send them fake signals. > > Here live patching consistency model call klp_send_signals to

Re: [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD

2021-03-24 Thread Joe Lawrence
On 3/24/21 9:48 PM, Dong Kai wrote: commit 15b2219facad ("kernel: freezer should treat PF_IO_WORKER like PF_KTHREAD for freezing") is to fix the freezeing issue of IO threads nit: s/freezeing/freezing by making the freezer not send them fake signals. Here live patching consistency model call

[PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD

2021-03-24 Thread Dong Kai
commit 15b2219facad ("kernel: freezer should treat PF_IO_WORKER like PF_KTHREAD for freezing") is to fix the freezeing issue of IO threads by making the freezer not send them fake signals. Here live patching consistency model call klp_send_signals to wake up all tasks by send fake signal to all no