Re: [PATCH] lkdtm: don't move ctors to .rodata

2021-02-14 Thread Sasha Levin
On Sun, Feb 14, 2021 at 06:16:29PM +0100, Greg Kroah-Hartman wrote: On Thu, Feb 11, 2021 at 10:53:10AM -0800, Stephen Boyd wrote: Sorry for the confusion. Can commit 65538943 ("vmlinux.lds.h: Create section for protection against instrumentation") and commit 3f618ab33234 ("lkdtm: don't move

Re: [PATCH] lkdtm: don't move ctors to .rodata

2021-02-14 Thread Stephen Boyd
Quoting Greg Kroah-Hartman (2021-02-14 09:16:29) > On Thu, Feb 11, 2021 at 10:53:10AM -0800, Stephen Boyd wrote: > > > > Sorry for the confusion. Can commit 65538943 ("vmlinux.lds.h: Create > > section for protection against instrumentation") and commit 3f618ab33234 > > ("lkdtm: don't move cto

Re: [PATCH] lkdtm: don't move ctors to .rodata

2021-02-14 Thread Greg Kroah-Hartman
On Thu, Feb 11, 2021 at 10:53:10AM -0800, Stephen Boyd wrote: > Quoting Greg Kroah-Hartman (2021-02-11 06:23:10) > > On Wed, Feb 10, 2021 at 04:36:08PM -0800, Stephen Boyd wrote: > > > Quoting Greg Kroah-Hartman (2020-12-09 06:51:33) > > > > On Tue, Dec 08, 2020 at 01:20:56PM -0800, Kees Cook wrote

Re: [PATCH] lkdtm: don't move ctors to .rodata

2021-02-11 Thread Stephen Boyd
Quoting Greg Kroah-Hartman (2021-02-11 06:23:10) > On Wed, Feb 10, 2021 at 04:36:08PM -0800, Stephen Boyd wrote: > > Quoting Greg Kroah-Hartman (2020-12-09 06:51:33) > > > On Tue, Dec 08, 2020 at 01:20:56PM -0800, Kees Cook wrote: > > > > On Mon, Dec 07, 2020 at 05:05:33PM +, Mark Rutland wrote

Re: [PATCH] lkdtm: don't move ctors to .rodata

2021-02-11 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2021 at 04:36:08PM -0800, Stephen Boyd wrote: > Quoting Greg Kroah-Hartman (2020-12-09 06:51:33) > > On Tue, Dec 08, 2020 at 01:20:56PM -0800, Kees Cook wrote: > > > On Mon, Dec 07, 2020 at 05:05:33PM +, Mark Rutland wrote: > > > > When building with KASAN and LKDTM, clang may i

Re: [PATCH] lkdtm: don't move ctors to .rodata

2021-02-10 Thread Stephen Boyd
Quoting Greg Kroah-Hartman (2020-12-09 06:51:33) > On Tue, Dec 08, 2020 at 01:20:56PM -0800, Kees Cook wrote: > > On Mon, Dec 07, 2020 at 05:05:33PM +, Mark Rutland wrote: > > > When building with KASAN and LKDTM, clang may implictly generate an > > > asan.module_ctor function in the LKDTM roda

Re: [PATCH] lkdtm: don't move ctors to .rodata

2020-12-09 Thread Greg Kroah-Hartman
On Tue, Dec 08, 2020 at 01:20:56PM -0800, Kees Cook wrote: > On Mon, Dec 07, 2020 at 05:05:33PM +, Mark Rutland wrote: > > When building with KASAN and LKDTM, clang may implictly generate an > > asan.module_ctor function in the LKDTM rodata object. The Makefile moves > > the lkdtm_rodata_do_not

Re: [PATCH] lkdtm: don't move ctors to .rodata

2020-12-08 Thread Kees Cook
On Mon, Dec 07, 2020 at 05:05:33PM +, Mark Rutland wrote: > When building with KASAN and LKDTM, clang may implictly generate an > asan.module_ctor function in the LKDTM rodata object. The Makefile moves > the lkdtm_rodata_do_nothing() function into .rodata by renaming the > file's .text section

[PATCH] lkdtm: don't move ctors to .rodata

2020-12-07 Thread Mark Rutland
When building with KASAN and LKDTM, clang may implictly generate an asan.module_ctor function in the LKDTM rodata object. The Makefile moves the lkdtm_rodata_do_nothing() function into .rodata by renaming the file's .text section to .rodata, and consequently also moves the ctor function into .rodat