Re: [PATCH] llist: Fix missing memory barrier

2015-02-06 Thread Greg Kroah-Hartman
, "Paul McKenney" > > , "David Howells" > > Sent: Friday, February 6, 2015 10:03:59 AM > > Subject: Re: [PATCH] llist: Fix missing memory barrier > > > > On Fri, Feb 06, 2015 at 02:12:32PM +, Mathieu Desnoyers wrote: > > > - Ori

Re: [PATCH] llist: Fix missing memory barrier

2015-02-06 Thread Mathieu Desnoyers
- Original Message - > From: "Peter Hurley" > To: "Mathieu Desnoyers" , "Pranith Kumar" > > Cc: "Huang Ying" , "LKML" > , "Paul McKenney" > , "David Howells" , "Greg > Kroah-Hartman&q

Re: [PATCH] llist: Fix missing memory barrier

2015-02-06 Thread Mathieu Desnoyers
- Original Message - > From: "Greg Kroah-Hartman" > To: "Mathieu Desnoyers" > Cc: "Pranith Kumar" , "Huang Ying" > , "LKML" > , "Paul McKenney" , > "David Howells" > Sent: Friday, February 6, 20

Re: [PATCH] llist: Fix missing memory barrier

2015-02-06 Thread Peter Hurley
On 02/06/2015 09:12 AM, Mathieu Desnoyers wrote: > - Original Message - >> From: "Pranith Kumar" >> To: "Mathieu Desnoyers" >> Cc: "Huang Ying" , "LKML" >> , "Paul McKenney" >> , "David Howells"

Re: [PATCH] llist: Fix missing memory barrier

2015-02-06 Thread Greg Kroah-Hartman
, "David Howells" > > Sent: Thursday, February 5, 2015 10:44:07 PM > > Subject: Re: [PATCH] llist: Fix missing memory barrier > > > > Hi Mathieu, > > > > On Thu, Feb 5, 2015 at 10:06 PM, Mathieu Desnoyers > > wrote: > > > A smp_read_bar

Re: [PATCH] llist: Fix missing memory barrier

2015-02-06 Thread Mathieu Desnoyers
- Original Message - > From: "Pranith Kumar" > To: "Mathieu Desnoyers" > Cc: "Huang Ying" , "LKML" > , "Paul McKenney" > , "David Howells" > Sent: Thursday, February 5, 2015 10:44:07 PM > Subject: Re: [P

Re: [PATCH] llist: Fix missing memory barrier

2015-02-05 Thread Pranith Kumar
Hi Mathieu, On Thu, Feb 5, 2015 at 10:06 PM, Mathieu Desnoyers wrote: > A smp_read_barrier_depends() appears to be missing in llist_del_first(). > It should only matter for Alpha in practice. Adding it after the check > of entry against NULL allows skipping the barrier in a common case. We recen

[PATCH] llist: Fix missing memory barrier

2015-02-05 Thread Mathieu Desnoyers
A smp_read_barrier_depends() appears to be missing in llist_del_first(). It should only matter for Alpha in practice. Adding it after the check of entry against NULL allows skipping the barrier in a common case. Signed-off-by: Mathieu Desnoyers CC: Huang Ying CC: Paul McKenney CC: David Howells