Re: [PATCH] lockdep: report broken irq restoration

2021-01-04 Thread Mark Rutland
On Thu, Dec 17, 2020 at 03:36:40PM +0100, Peter Zijlstra wrote: > On Wed, Dec 09, 2020 at 06:33:37PM +, Mark Rutland wrote: > > This means that a seuence such as: > > +q > > > diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h > > index 3ed4e8771b64..bca3c6fa8270 100644 > > ---

Re: [PATCH] lockdep: report broken irq restoration

2020-12-17 Thread Peter Zijlstra
On Wed, Dec 09, 2020 at 06:33:37PM +, Mark Rutland wrote: > This means that a seuence such as: +q > diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h > index 3ed4e8771b64..bca3c6fa8270 100644 > --- a/include/linux/irqflags.h > +++ b/include/linux/irqflags.h > @@ -220,10

Re: [PATCH] lockdep: report broken irq restoration

2020-12-10 Thread Mark Rutland
On Wed, Dec 09, 2020 at 11:05:21AM -0800, Andy Lutomirski wrote: > On Wed, Dec 9, 2020 at 10:33 AM Mark Rutland wrote: > > diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h > > index 3ed4e8771b64..bca3c6fa8270 100644 > > --- a/include/linux/irqflags.h > > +++

Re: [PATCH] lockdep: report broken irq restoration

2020-12-09 Thread Andy Lutomirski
On Wed, Dec 9, 2020 at 10:33 AM Mark Rutland wrote: > > We generally expect local_irq_save() and local_irq_restore() to be > paired and sanely nested, and so local_irq_restore() expects to be > called with irqs disabled. Thus, within local_irq_restore() we only > trace irq flag changes when

[PATCH] lockdep: report broken irq restoration

2020-12-09 Thread Mark Rutland
We generally expect local_irq_save() and local_irq_restore() to be paired and sanely nested, and so local_irq_restore() expects to be called with irqs disabled. Thus, within local_irq_restore() we only trace irq flag changes when unmasking irqs. This means that a seuence such as: |