Re: [PATCH] locking/atomics/powerpc: Move cmpxchg helpers to asm/cmpxchg.h and define the full set of cmpxchg APIs

2018-05-07 Thread Ingo Molnar
* Boqun Feng wrote: > > > On Sun, May 6, 2018, at 8:11 PM, Ingo Molnar wrote: > > > > * Boqun Feng wrote: > > > > > > The only change I made beyond a trivial build fix is that I also added > > > > the release > > > > atomics variants

Re: [PATCH] locking/atomics/powerpc: Move cmpxchg helpers to asm/cmpxchg.h and define the full set of cmpxchg APIs

2018-05-07 Thread Ingo Molnar
* Boqun Feng wrote: > > > On Sun, May 6, 2018, at 8:11 PM, Ingo Molnar wrote: > > > > * Boqun Feng wrote: > > > > > > The only change I made beyond a trivial build fix is that I also added > > > > the release > > > > atomics variants explicitly: > > > > > > > > +#define

Re: [PATCH] locking/atomics/powerpc: Move cmpxchg helpers to asm/cmpxchg.h and define the full set of cmpxchg APIs

2018-05-06 Thread Boqun Feng
On Sun, May 6, 2018, at 8:11 PM, Ingo Molnar wrote: > > * Boqun Feng wrote: > > > > The only change I made beyond a trivial build fix is that I also added > > > the release > > > atomics variants explicitly: > > > > > > +#define atomic_cmpxchg_release(v, o, n) \ > > >

Re: [PATCH] locking/atomics/powerpc: Move cmpxchg helpers to asm/cmpxchg.h and define the full set of cmpxchg APIs

2018-05-06 Thread Boqun Feng
On Sun, May 6, 2018, at 8:11 PM, Ingo Molnar wrote: > > * Boqun Feng wrote: > > > > The only change I made beyond a trivial build fix is that I also added > > > the release > > > atomics variants explicitly: > > > > > > +#define atomic_cmpxchg_release(v, o, n) \ > > > +

Re: [PATCH] locking/atomics/powerpc: Move cmpxchg helpers to asm/cmpxchg.h and define the full set of cmpxchg APIs

2018-05-06 Thread Ingo Molnar
* Boqun Feng wrote: > > The only change I made beyond a trivial build fix is that I also added the > > release > > atomics variants explicitly: > > > > +#define atomic_cmpxchg_release(v, o, n) \ > > + cmpxchg_release(&((v)->counter), (o), (n)) > > +#define

Re: [PATCH] locking/atomics/powerpc: Move cmpxchg helpers to asm/cmpxchg.h and define the full set of cmpxchg APIs

2018-05-06 Thread Ingo Molnar
* Boqun Feng wrote: > > The only change I made beyond a trivial build fix is that I also added the > > release > > atomics variants explicitly: > > > > +#define atomic_cmpxchg_release(v, o, n) \ > > + cmpxchg_release(&((v)->counter), (o), (n)) > > +#define atomic64_cmpxchg_release(v, o, n)

Re: [PATCH] locking/atomics/powerpc: Move cmpxchg helpers to asm/cmpxchg.h and define the full set of cmpxchg APIs

2018-05-05 Thread Boqun Feng
On Sat, May 05, 2018 at 03:27:51PM +0200, Ingo Molnar wrote: > > * Boqun Feng wrote: > > > > May I suggest the patch below? No change in functionality, but it > > > documents the > > > lack of the cmpxchg_release() APIs and maps them explicitly to the full > > >

Re: [PATCH] locking/atomics/powerpc: Move cmpxchg helpers to asm/cmpxchg.h and define the full set of cmpxchg APIs

2018-05-05 Thread Boqun Feng
On Sat, May 05, 2018 at 03:27:51PM +0200, Ingo Molnar wrote: > > * Boqun Feng wrote: > > > > May I suggest the patch below? No change in functionality, but it > > > documents the > > > lack of the cmpxchg_release() APIs and maps them explicitly to the full > > > cmpxchg() > > > version.

[PATCH] locking/atomics/powerpc: Move cmpxchg helpers to asm/cmpxchg.h and define the full set of cmpxchg APIs

2018-05-05 Thread Ingo Molnar
* Boqun Feng wrote: > > May I suggest the patch below? No change in functionality, but it documents > > the > > lack of the cmpxchg_release() APIs and maps them explicitly to the full > > cmpxchg() > > version. (Which the generic code does now in a rather roundabout

[PATCH] locking/atomics/powerpc: Move cmpxchg helpers to asm/cmpxchg.h and define the full set of cmpxchg APIs

2018-05-05 Thread Ingo Molnar
* Boqun Feng wrote: > > May I suggest the patch below? No change in functionality, but it documents > > the > > lack of the cmpxchg_release() APIs and maps them explicitly to the full > > cmpxchg() > > version. (Which the generic code does now in a rather roundabout way.) > > > > Hmm..