Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-14 Thread xinhui
On 2016年06月14日 18:40, Will Deacon wrote: On Tue, Jun 14, 2016 at 02:11:48PM +0800, xinhui wrote: On 2016年06月08日 17:22, Will Deacon wrote: On Thu, Jun 02, 2016 at 06:09:08PM +0800, Pan Xinhui wrote: strcut __qrwlock has different layout in big endian machine. we need set the

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-14 Thread xinhui
On 2016年06月14日 18:40, Will Deacon wrote: On Tue, Jun 14, 2016 at 02:11:48PM +0800, xinhui wrote: On 2016年06月08日 17:22, Will Deacon wrote: On Thu, Jun 02, 2016 at 06:09:08PM +0800, Pan Xinhui wrote: strcut __qrwlock has different layout in big endian machine. we need set the

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-14 Thread Will Deacon
On Tue, Jun 14, 2016 at 02:11:48PM +0800, xinhui wrote: > > On 2016年06月08日 17:22, Will Deacon wrote: > >On Thu, Jun 02, 2016 at 06:09:08PM +0800, Pan Xinhui wrote: > >>strcut __qrwlock has different layout in big endian machine. we need set > >>the __qrwlock->wmode to NULL, and the address is not

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-14 Thread Will Deacon
On Tue, Jun 14, 2016 at 02:11:48PM +0800, xinhui wrote: > > On 2016年06月08日 17:22, Will Deacon wrote: > >On Thu, Jun 02, 2016 at 06:09:08PM +0800, Pan Xinhui wrote: > >>strcut __qrwlock has different layout in big endian machine. we need set > >>the __qrwlock->wmode to NULL, and the address is not

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-14 Thread xinhui
On 2016年06月08日 17:22, Will Deacon wrote: On Thu, Jun 02, 2016 at 06:09:08PM +0800, Pan Xinhui wrote: strcut __qrwlock has different layout in big endian machine. we need set the __qrwlock->wmode to NULL, and the address is not >cnts in big endian machine. Do as what read unlock does. we are

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-14 Thread xinhui
On 2016年06月08日 17:22, Will Deacon wrote: On Thu, Jun 02, 2016 at 06:09:08PM +0800, Pan Xinhui wrote: strcut __qrwlock has different layout in big endian machine. we need set the __qrwlock->wmode to NULL, and the address is not >cnts in big endian machine. Do as what read unlock does. we are

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-08 Thread Will Deacon
On Thu, Jun 02, 2016 at 06:09:08PM +0800, Pan Xinhui wrote: > strcut __qrwlock has different layout in big endian machine. we need set > the __qrwlock->wmode to NULL, and the address is not >cnts in big > endian machine. > > Do as what read unlock does. we are lucky that the __qrwlock->wmode's >

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-08 Thread Will Deacon
On Thu, Jun 02, 2016 at 06:09:08PM +0800, Pan Xinhui wrote: > strcut __qrwlock has different layout in big endian machine. we need set > the __qrwlock->wmode to NULL, and the address is not >cnts in big > endian machine. > > Do as what read unlock does. we are lucky that the __qrwlock->wmode's >

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-05 Thread xinhui
On 2016年06月04日 04:57, Waiman Long wrote: On 06/03/2016 03:17 AM, xinhui wrote: On 2016年06月02日 19:02, Peter Zijlstra wrote: On Thu, Jun 02, 2016 at 12:44:51PM +0200, Arnd Bergmann wrote: On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: diff --git a/include/asm-generic/qrwlock.h

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-05 Thread xinhui
On 2016年06月04日 04:57, Waiman Long wrote: On 06/03/2016 03:17 AM, xinhui wrote: On 2016年06月02日 19:02, Peter Zijlstra wrote: On Thu, Jun 02, 2016 at 12:44:51PM +0200, Arnd Bergmann wrote: On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: diff --git a/include/asm-generic/qrwlock.h

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-03 Thread Waiman Long
On 06/03/2016 03:17 AM, xinhui wrote: On 2016年06月02日 19:02, Peter Zijlstra wrote: On Thu, Jun 02, 2016 at 12:44:51PM +0200, Arnd Bergmann wrote: On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h index

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-03 Thread Waiman Long
On 06/03/2016 03:17 AM, xinhui wrote: On 2016年06月02日 19:02, Peter Zijlstra wrote: On Thu, Jun 02, 2016 at 12:44:51PM +0200, Arnd Bergmann wrote: On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h index

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-03 Thread xinhui
On 2016年06月02日 19:15, Peter Zijlstra wrote: On Thu, Jun 02, 2016 at 07:01:17PM +0800, xinhui wrote: On 2016年06月02日 18:44, Arnd Bergmann wrote: On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h index

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-03 Thread xinhui
On 2016年06月02日 19:15, Peter Zijlstra wrote: On Thu, Jun 02, 2016 at 07:01:17PM +0800, xinhui wrote: On 2016年06月02日 18:44, Arnd Bergmann wrote: On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h index

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-03 Thread xinhui
On 2016年06月02日 19:02, Peter Zijlstra wrote: On Thu, Jun 02, 2016 at 12:44:51PM +0200, Arnd Bergmann wrote: On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h index 54a8e65..eadd7a3 100644 ---

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-03 Thread xinhui
On 2016年06月02日 19:02, Peter Zijlstra wrote: On Thu, Jun 02, 2016 at 12:44:51PM +0200, Arnd Bergmann wrote: On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h index 54a8e65..eadd7a3 100644 ---

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-02 Thread Peter Zijlstra
On Thu, Jun 02, 2016 at 07:01:17PM +0800, xinhui wrote: > > On 2016年06月02日 18:44, Arnd Bergmann wrote: > >On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: > >>diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h > >>index 54a8e65..eadd7a3 100644 > >>---

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-02 Thread Peter Zijlstra
On Thu, Jun 02, 2016 at 07:01:17PM +0800, xinhui wrote: > > On 2016年06月02日 18:44, Arnd Bergmann wrote: > >On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: > >>diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h > >>index 54a8e65..eadd7a3 100644 > >>---

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-02 Thread xinhui
On 2016年06月02日 18:44, Arnd Bergmann wrote: On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h index 54a8e65..eadd7a3 100644 --- a/include/asm-generic/qrwlock.h +++ b/include/asm-generic/qrwlock.h @@ -139,7

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-02 Thread Peter Zijlstra
On Thu, Jun 02, 2016 at 12:44:51PM +0200, Arnd Bergmann wrote: > On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: > > diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h > > index 54a8e65..eadd7a3 100644 > > --- a/include/asm-generic/qrwlock.h > > +++

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-02 Thread xinhui
On 2016年06月02日 18:44, Arnd Bergmann wrote: On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h index 54a8e65..eadd7a3 100644 --- a/include/asm-generic/qrwlock.h +++ b/include/asm-generic/qrwlock.h @@ -139,7

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-02 Thread Peter Zijlstra
On Thu, Jun 02, 2016 at 12:44:51PM +0200, Arnd Bergmann wrote: > On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: > > diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h > > index 54a8e65..eadd7a3 100644 > > --- a/include/asm-generic/qrwlock.h > > +++

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-02 Thread Arnd Bergmann
On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: > diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h > index 54a8e65..eadd7a3 100644 > --- a/include/asm-generic/qrwlock.h > +++ b/include/asm-generic/qrwlock.h > @@ -139,7 +139,7 @@ static inline void

Re: [PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-02 Thread Arnd Bergmann
On Thursday, June 2, 2016 6:09:08 PM CEST Pan Xinhui wrote: > diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h > index 54a8e65..eadd7a3 100644 > --- a/include/asm-generic/qrwlock.h > +++ b/include/asm-generic/qrwlock.h > @@ -139,7 +139,7 @@ static inline void

[PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-02 Thread Pan Xinhui
strcut __qrwlock has different layout in big endian machine. we need set the __qrwlock->wmode to NULL, and the address is not >cnts in big endian machine. Do as what read unlock does. we are lucky that the __qrwlock->wmode's val is _QW_LOCKED. Signed-off-by: Pan Xinhui

[PATCH] locking/qrwlock: fix write unlock issue in big endian

2016-06-02 Thread Pan Xinhui
strcut __qrwlock has different layout in big endian machine. we need set the __qrwlock->wmode to NULL, and the address is not >cnts in big endian machine. Do as what read unlock does. we are lucky that the __qrwlock->wmode's val is _QW_LOCKED. Signed-off-by: Pan Xinhui ---