Re: [PATCH] locks: fix F_GETLK regression (failure to find conflicts)

2007-05-10 Thread Doug Chapman
On Thu, 2007-05-10 at 18:38 -0400, J. Bruce Fields wrote: > In 9d6a8c5c213e34c475e72b245a8eb709258e968c we changed posix_test_lock > to modify its single file_lock argument instead of taking separate input > and output arguments. This makes it no longer safe to set the output > lock's fl_type to

[PATCH] locks: fix F_GETLK regression (failure to find conflicts)

2007-05-10 Thread J. Bruce Fields
In 9d6a8c5c213e34c475e72b245a8eb709258e968c we changed posix_test_lock to modify its single file_lock argument instead of taking separate input and output arguments. This makes it no longer safe to set the output lock's fl_type to F_UNLCK before looking for a conflict, since that means searching

[PATCH] locks: fix F_GETLK regression (failure to find conflicts)

2007-05-10 Thread J. Bruce Fields
In 9d6a8c5c213e34c475e72b245a8eb709258e968c we changed posix_test_lock to modify its single file_lock argument instead of taking separate input and output arguments. This makes it no longer safe to set the output lock's fl_type to F_UNLCK before looking for a conflict, since that means searching

Re: [PATCH] locks: fix F_GETLK regression (failure to find conflicts)

2007-05-10 Thread Doug Chapman
On Thu, 2007-05-10 at 18:38 -0400, J. Bruce Fields wrote: In 9d6a8c5c213e34c475e72b245a8eb709258e968c we changed posix_test_lock to modify its single file_lock argument instead of taking separate input and output arguments. This makes it no longer safe to set the output lock's fl_type to