Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-29 Thread Michael Kerrisk (man-pages)
On 04/29/2014 01:34 PM, Jeff Layton wrote: > On Tue, 29 Apr 2014 11:53:40 +0200 > "Michael Kerrisk (man-pages)" wrote: > >> On 04/29/2014 11:24 AM, NeilBrown wrote: >>> On Tue, 29 Apr 2014 11:07:16 +0200 "Michael Kerrisk (man-pages)" >>> wrote: >>> On 04/27/2014 11:28 PM, NeilBrown wrote:

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-29 Thread Jeff Layton
On Tue, 29 Apr 2014 11:53:40 +0200 "Michael Kerrisk (man-pages)" wrote: > On 04/29/2014 11:24 AM, NeilBrown wrote: > > On Tue, 29 Apr 2014 11:07:16 +0200 "Michael Kerrisk (man-pages)" > > wrote: > > > >> On 04/27/2014 11:28 PM, NeilBrown wrote: > >>> On Sun, 27 Apr 2014 13:11:33 +0200 "Michael

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-29 Thread Michael Kerrisk (man-pages)
On 04/29/2014 11:24 AM, NeilBrown wrote: > On Tue, 29 Apr 2014 11:07:16 +0200 "Michael Kerrisk (man-pages)" > wrote: > >> On 04/27/2014 11:28 PM, NeilBrown wrote: >>> On Sun, 27 Apr 2014 13:11:33 +0200 "Michael Kerrisk (man-pages)" >>> wrote: >>> On Sun, Apr 27, 2014 at 12:04 PM, NeilBrown

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-29 Thread NeilBrown
On Tue, 29 Apr 2014 11:07:16 +0200 "Michael Kerrisk (man-pages)" wrote: > On 04/27/2014 11:28 PM, NeilBrown wrote: > > On Sun, 27 Apr 2014 13:11:33 +0200 "Michael Kerrisk (man-pages)" > > wrote: > > > >> On Sun, Apr 27, 2014 at 12:04 PM, NeilBrown wrote: > >>> On Sun, 27 Apr 2014 11:16:02

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-29 Thread Michael Kerrisk (man-pages)
On 04/27/2014 11:28 PM, NeilBrown wrote: > On Sun, 27 Apr 2014 13:11:33 +0200 "Michael Kerrisk (man-pages)" > wrote: > >> On Sun, Apr 27, 2014 at 12:04 PM, NeilBrown wrote: >>> On Sun, 27 Apr 2014 11:16:02 +0200 "Michael Kerrisk (man-pages)" >>> wrote: >>> [Trimming some folk from CC, and

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-29 Thread Michael Kerrisk (man-pages)
On 04/27/2014 11:28 PM, NeilBrown wrote: On Sun, 27 Apr 2014 13:11:33 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On Sun, Apr 27, 2014 at 12:04 PM, NeilBrown ne...@suse.de wrote: On Sun, 27 Apr 2014 11:16:02 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote:

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-29 Thread NeilBrown
On Tue, 29 Apr 2014 11:07:16 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/27/2014 11:28 PM, NeilBrown wrote: On Sun, 27 Apr 2014 13:11:33 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On Sun, Apr 27, 2014 at 12:04 PM, NeilBrown ne...@suse.de

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-29 Thread Michael Kerrisk (man-pages)
On 04/29/2014 11:24 AM, NeilBrown wrote: On Tue, 29 Apr 2014 11:07:16 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/27/2014 11:28 PM, NeilBrown wrote: On Sun, 27 Apr 2014 13:11:33 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On Sun, Apr 27, 2014

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-29 Thread Jeff Layton
On Tue, 29 Apr 2014 11:53:40 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/29/2014 11:24 AM, NeilBrown wrote: On Tue, 29 Apr 2014 11:07:16 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/27/2014 11:28 PM, NeilBrown wrote: On Sun, 27 Apr

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-29 Thread Michael Kerrisk (man-pages)
On 04/29/2014 01:34 PM, Jeff Layton wrote: On Tue, 29 Apr 2014 11:53:40 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/29/2014 11:24 AM, NeilBrown wrote: On Tue, 29 Apr 2014 11:07:16 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/27/2014 11:28

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-28 Thread NeilBrown
On Mon, 28 Apr 2014 06:23:21 -0400 Jeff Layton wrote: > I sent a pull request to Linus last week and he merged the patches over > the weekend. So yes, this ship has sailed unless someone feels strongly > enough about it to roll up the patches to change it. > > I think we'll probably come to

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-28 Thread Jeff Layton
On Sun, 27 Apr 2014 14:51:25 +1000 NeilBrown wrote: > On Tue, 22 Apr 2014 06:54:36 +0200 "Michael Kerrisk (man-pages)" > wrote: > > > On 04/21/2014 11:15 PM, Stefan (metze) Metzmacher wrote: > > > Am 21.04.2014 21:55, schrieb Jeff Layton: > > >> On Mon, 21 Apr 2014 21:39:12 +0200 > > >>

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-28 Thread Jeff Layton
On Sun, 27 Apr 2014 14:51:25 +1000 NeilBrown ne...@suse.de wrote: On Tue, 22 Apr 2014 06:54:36 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/21/2014 11:15 PM, Stefan (metze) Metzmacher wrote: Am 21.04.2014 21:55, schrieb Jeff Layton: On Mon, 21 Apr 2014

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-28 Thread NeilBrown
On Mon, 28 Apr 2014 06:23:21 -0400 Jeff Layton jlay...@redhat.com wrote: I sent a pull request to Linus last week and he merged the patches over the weekend. So yes, this ship has sailed unless someone feels strongly enough about it to roll up the patches to change it. I think we'll

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-27 Thread NeilBrown
On Sun, 27 Apr 2014 13:11:33 +0200 "Michael Kerrisk (man-pages)" wrote: > On Sun, Apr 27, 2014 at 12:04 PM, NeilBrown wrote: > > On Sun, 27 Apr 2014 11:16:02 +0200 "Michael Kerrisk (man-pages)" > > wrote: > > > >> [Trimming some folk from CC, and adding various NFS people] > >> > >> On

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-27 Thread Michael Kerrisk (man-pages)
On Sun, Apr 27, 2014 at 12:04 PM, NeilBrown wrote: > On Sun, 27 Apr 2014 11:16:02 +0200 "Michael Kerrisk (man-pages)" > wrote: > >> [Trimming some folk from CC, and adding various NFS people] >> >> On 04/27/2014 06:51 AM, NeilBrown wrote: >> >> [...] >> >> > Note to Michael: The text >> >

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-27 Thread NeilBrown
On Sun, 27 Apr 2014 11:16:02 +0200 "Michael Kerrisk (man-pages)" wrote: > [Trimming some folk from CC, and adding various NFS people] > > On 04/27/2014 06:51 AM, NeilBrown wrote: > > [...] > > > Note to Michael: The text > >flock() does not lock files over NFS. > > in flock(2) is no

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-27 Thread Michael Kerrisk (man-pages)
On 04/27/2014 06:51 AM, NeilBrown wrote: > On Tue, 22 Apr 2014 06:54:36 +0200 "Michael Kerrisk (man-pages)" > wrote: > >> On 04/21/2014 11:15 PM, Stefan (metze) Metzmacher wrote: >>> Am 21.04.2014 21:55, schrieb Jeff Layton: On Mon, 21 Apr 2014 21:39:12 +0200 "Michael Kerrisk

flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-27 Thread Michael Kerrisk (man-pages)
[Trimming some folk from CC, and adding various NFS people] On 04/27/2014 06:51 AM, NeilBrown wrote: [...] > Note to Michael: The text >flock() does not lock files over NFS. > in flock(2) is no longer accurate. The reality is ... complex. > See nfs(5), and search for "local_lock". Ahhh --

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-27 Thread NeilBrown
On Sun, 27 Apr 2014 13:11:33 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On Sun, Apr 27, 2014 at 12:04 PM, NeilBrown ne...@suse.de wrote: On Sun, 27 Apr 2014 11:16:02 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: [Trimming some folk from CC, and

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-27 Thread Michael Kerrisk (man-pages)
On 04/27/2014 06:51 AM, NeilBrown wrote: On Tue, 22 Apr 2014 06:54:36 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/21/2014 11:15 PM, Stefan (metze) Metzmacher wrote: Am 21.04.2014 21:55, schrieb Jeff Layton: On Mon, 21 Apr 2014 21:39:12 +0200 Michael Kerrisk

flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-27 Thread Michael Kerrisk (man-pages)
[Trimming some folk from CC, and adding various NFS people] On 04/27/2014 06:51 AM, NeilBrown wrote: [...] Note to Michael: The text flock() does not lock files over NFS. in flock(2) is no longer accurate. The reality is ... complex. See nfs(5), and search for local_lock. Ahhh -- I

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-27 Thread NeilBrown
On Sun, 27 Apr 2014 11:16:02 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: [Trimming some folk from CC, and adding various NFS people] On 04/27/2014 06:51 AM, NeilBrown wrote: [...] Note to Michael: The text flock() does not lock files over NFS. in flock(2) is

Re: flock() and NFS [Was: Re: [PATCH] locks: rename file-private locks to file-description locks]

2014-04-27 Thread Michael Kerrisk (man-pages)
On Sun, Apr 27, 2014 at 12:04 PM, NeilBrown ne...@suse.de wrote: On Sun, 27 Apr 2014 11:16:02 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: [Trimming some folk from CC, and adding various NFS people] On 04/27/2014 06:51 AM, NeilBrown wrote: [...] Note to Michael: The

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-26 Thread NeilBrown
On Tue, 22 Apr 2014 06:54:36 +0200 "Michael Kerrisk (man-pages)" wrote: > On 04/21/2014 11:15 PM, Stefan (metze) Metzmacher wrote: > > Am 21.04.2014 21:55, schrieb Jeff Layton: > >> On Mon, 21 Apr 2014 21:39:12 +0200 > >> "Michael Kerrisk (man-pages)" wrote: > >> > >>> On 04/21/2014 08:46 PM,

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-26 Thread NeilBrown
On Tue, 22 Apr 2014 06:54:36 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/21/2014 11:15 PM, Stefan (metze) Metzmacher wrote: Am 21.04.2014 21:55, schrieb Jeff Layton: On Mon, 21 Apr 2014 21:39:12 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote:

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 11:15 PM, Stefan (metze) Metzmacher wrote: > Am 21.04.2014 21:55, schrieb Jeff Layton: >> On Mon, 21 Apr 2014 21:39:12 +0200 >> "Michael Kerrisk (man-pages)" wrote: >> >>> On 04/21/2014 08:46 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Stefan (metze) Metzmacher
Am 21.04.2014 21:55, schrieb Jeff Layton: > On Mon, 21 Apr 2014 21:39:12 +0200 > "Michael Kerrisk (man-pages)" wrote: > >> On 04/21/2014 08:46 PM, Rich Felker wrote: >>> On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: On 04/21/2014 06:10 PM, Rich Felker wrote:

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 03:04:10PM -0400, Theodore Ts'o wrote: > On Mon, Apr 21, 2014 at 02:51:44PM -0400, Rich Felker wrote: > > I don't think "struct file" has any meaning to any userspace > > developers, and as such doesn't belong in documentation for userspace > > programming. It's an

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 03:16:29PM -0400, Jeff Layton wrote: > On Mon, 21 Apr 2014 14:48:29 -0400 > Rich Felker wrote: > > > On Mon, Apr 21, 2014 at 02:32:38PM -0400, Jeff Layton wrote: > > > > > Fair enough. Assuming we kept "file-description locks" as a name, what > > > > > would you propose

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 09:06 PM, Christoph Hellwig wrote: > On Mon, Apr 21, 2014 at 03:04:10PM -0400, Theodore Ts'o wrote: >> I think what you mean is that there is no need that we expose the name >> "struct file". My point is that "struct file" is actually a much >> _better_ name than "file description".

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
On Mon, 21 Apr 2014 21:39:12 +0200 "Michael Kerrisk (man-pages)" wrote: > On 04/21/2014 08:46 PM, Rich Felker wrote: > > On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: > >> On 04/21/2014 06:10 PM, Rich Felker wrote: > >>> I'm well aware of that. The problem is that

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 08:46 PM, Rich Felker wrote: > On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: >> On 04/21/2014 06:10 PM, Rich Felker wrote: >>> I'm well aware of that. The problem is that the proposed API is using >>> the two-letter abbreviation FD, which ALWAYS means

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
On Mon, 21 Apr 2014 14:48:29 -0400 Rich Felker wrote: > On Mon, Apr 21, 2014 at 02:32:38PM -0400, Jeff Layton wrote: > > > > Fair enough. Assuming we kept "file-description locks" as a name, what > > > > would you propose as new macro names? > > > > > > I assume you meant, "assume we kept the

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Christoph Hellwig
On Mon, Apr 21, 2014 at 03:04:10PM -0400, Theodore Ts'o wrote: > I think what you mean is that there is no need that we expose the name > "struct file". My point is that "struct file" is actually a much > _better_ name than "file description". Heck, "open file object" would > be better name than

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Theodore Ts'o
On Mon, Apr 21, 2014 at 02:51:44PM -0400, Rich Felker wrote: > I don't think "struct file" has any meaning to any userspace > developers, and as such doesn't belong in documentation for userspace > programming. It's an implementation detail of the kernel that > userspace developers have no need to

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 02:48:41PM -0400, Theodore Ts'o wrote: > On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: > > So, can you *please* answer this question: what do you call (i.e., > > what everyday technical language term do use for) the thing > > that sits

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Theodore Ts'o
On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: > So, can you *please* answer this question: what do you call (i.e., > what everyday technical language term do use for) the thing > that sits between a file descriptor and an i-node? > > (Please don't say 'struct

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 02:32:38PM -0400, Jeff Layton wrote: > > > Fair enough. Assuming we kept "file-description locks" as a name, what > > > would you propose as new macro names? > > > > I assume you meant, "assume we kept the term 'file-private locks'..." > > In that case, at least make the

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: > On 04/21/2014 06:10 PM, Rich Felker wrote: > > I'm well aware of that. The problem is that the proposed API is using > > the two-letter abbreviation FD, which ALWAYS means file descriptor and > > NEVER means file

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 08:01 PM, Andy Lutomirski wrote: > On 04/21/2014 09:45 AM, Jeff Layton wrote: >> On Mon, 21 Apr 2014 12:10:04 -0400 >> Rich Felker wrote: >>> I'm well aware of that. The problem is that the proposed API is using >>> the two-letter abbreviation FD, which ALWAYS means file descriptor

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 08:34 PM, Christoph Hellwig wrote: > On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: >> So, can you *please* answer this question: what do you call (i.e., >> what everyday technical language term do use for) the thing >> that sits between a file

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Christoph Hellwig
On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: > So, can you *please* answer this question: what do you call (i.e., > what everyday technical language term do use for) the thing > that sits between a file descriptor and an i-node? An open file. -- To unsubscribe

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
On Mon, 21 Apr 2014 20:18:50 +0200 "Michael Kerrisk (man-pages)" wrote: > Jeff, > On 04/21/2014 06:45 PM, Jeff Layton wrote: > > On Mon, 21 Apr 2014 12:10:04 -0400 > > Rich Felker wrote: > > > >> On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) > >> wrote: > >>> On

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 06:10 PM, Rich Felker wrote: > On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: >> On 04/21/2014 04:02 PM, Rich Felker wrote: >>> On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote: File-private locks have been merged into Linux for v3.15,

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
Christoph, On 04/21/2014 06:09 PM, Christoph Hellwig wrote: > On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: >> >> There's at least two problems to solve here: >> >> 1) "File private locks" is _meaningless_ as a term. Elsewhere >> >>

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
Jeff, On 04/21/2014 06:45 PM, Jeff Layton wrote: > On Mon, 21 Apr 2014 12:10:04 -0400 > Rich Felker wrote: > >> On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: >>> On 04/21/2014 04:02 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Andy Lutomirski
On 04/21/2014 09:45 AM, Jeff Layton wrote: > On Mon, 21 Apr 2014 12:10:04 -0400 > Rich Felker wrote: >> I'm well aware of that. The problem is that the proposed API is using >> the two-letter abbreviation FD, which ALWAYS means file descriptor and >> NEVER means file description (in existing

RE: [Nfs-ganesha-devel] [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Frank Filz
> On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) > wrote: > > > > There's at least two problems to solve here: > > > > 1) "File private locks" is _meaningless_ as a term. Elsewhere > > > > > (http://thread.gmane.org/gmane.network.samba.internals/76414/focus=16 > 8 > > 5376),

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
On Mon, 21 Apr 2014 09:09:27 -0700 Christoph Hellwig wrote: > On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: > > > > There's at least two problems to solve here: > > > > 1) "File private locks" is _meaningless_ as a term. Elsewhere > > > >

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
On Mon, 21 Apr 2014 12:10:04 -0400 Rich Felker wrote: > On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: > > On 04/21/2014 04:02 PM, Rich Felker wrote: > > > On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote: > > >> File-private locks have been merged into

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: > On 04/21/2014 04:02 PM, Rich Felker wrote: > > On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote: > >> File-private locks have been merged into Linux for v3.15, and *now* > >> people are commenting that the

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Christoph Hellwig
On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: > > There's at least two problems to solve here: > > 1) "File private locks" is _meaningless_ as a term. Elsewhere > > (http://thread.gmane.org/gmane.network.samba.internals/76414/focus=1685376), It's indeed not a

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Stefan (metze) Metzmacher
Am 21.04.2014 15:45, schrieb Jeff Layton: > File-private locks have been merged into Linux for v3.15, and *now* > people are commenting that the name and macro definitions for the new > file-private locks suck. > > ...and I can't even disagree. The names and command macros do suck. > > We're

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 03:45 PM, Jeff Layton wrote: [...] > - * These cmd values will set locks that conflict with normal POSIX locks, but > - * are "owned" by the opened file, not the process. This means that they are > - * inherited across fork() like BSD (flock) locks, and they are only released > - *

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 04:02 PM, Rich Felker wrote: > On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote: >> File-private locks have been merged into Linux for v3.15, and *now* >> people are commenting that the name and macro definitions for the new >> file-private locks suck. >> >> and I

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote: > File-private locks have been merged into Linux for v3.15, and *now* > people are commenting that the name and macro definitions for the new > file-private locks suck. > > and I can't even disagree. The names and command macros do

[PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
File-private locks have been merged into Linux for v3.15, and *now* people are commenting that the name and macro definitions for the new file-private locks suck. ...and I can't even disagree. The names and command macros do suck. We're going to have to live with these for a long time, so it's

[PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
File-private locks have been merged into Linux for v3.15, and *now* people are commenting that the name and macro definitions for the new file-private locks suck. ...and I can't even disagree. The names and command macros do suck. We're going to have to live with these for a long time, so it's

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote: File-private locks have been merged into Linux for v3.15, and *now* people are commenting that the name and macro definitions for the new file-private locks suck. and I can't even disagree. The names and command macros do suck.

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 04:02 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote: File-private locks have been merged into Linux for v3.15, and *now* people are commenting that the name and macro definitions for the new file-private locks suck. and I can't even

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 03:45 PM, Jeff Layton wrote: [...] - * These cmd values will set locks that conflict with normal POSIX locks, but - * are owned by the opened file, not the process. This means that they are - * inherited across fork() like BSD (flock) locks, and they are only released - *

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Stefan (metze) Metzmacher
Am 21.04.2014 15:45, schrieb Jeff Layton: File-private locks have been merged into Linux for v3.15, and *now* people are commenting that the name and macro definitions for the new file-private locks suck. ...and I can't even disagree. The names and command macros do suck. We're going to

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Christoph Hellwig
On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: There's at least two problems to solve here: 1) File private locks is _meaningless_ as a term. Elsewhere (http://thread.gmane.org/gmane.network.samba.internals/76414/focus=1685376), It's indeed not a very

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: On 04/21/2014 04:02 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote: File-private locks have been merged into Linux for v3.15, and *now* people are commenting that the name and

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
On Mon, 21 Apr 2014 12:10:04 -0400 Rich Felker dal...@libc.org wrote: On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: On 04/21/2014 04:02 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote: File-private locks have been merged

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
On Mon, 21 Apr 2014 09:09:27 -0700 Christoph Hellwig h...@infradead.org wrote: On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: There's at least two problems to solve here: 1) File private locks is _meaningless_ as a term. Elsewhere

RE: [Nfs-ganesha-devel] [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Frank Filz
On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: There's at least two problems to solve here: 1) File private locks is _meaningless_ as a term. Elsewhere (http://thread.gmane.org/gmane.network.samba.internals/76414/focus=16 8 5376), It's indeed not

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Andy Lutomirski
On 04/21/2014 09:45 AM, Jeff Layton wrote: On Mon, 21 Apr 2014 12:10:04 -0400 Rich Felker dal...@libc.org wrote: I'm well aware of that. The problem is that the proposed API is using the two-letter abbreviation FD, which ALWAYS means file descriptor and NEVER means file description (in

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
Jeff, On 04/21/2014 06:45 PM, Jeff Layton wrote: On Mon, 21 Apr 2014 12:10:04 -0400 Rich Felker dal...@libc.org wrote: On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: On 04/21/2014 04:02 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
Christoph, On 04/21/2014 06:09 PM, Christoph Hellwig wrote: On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: There's at least two problems to solve here: 1) File private locks is _meaningless_ as a term. Elsewhere

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 06:10 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote: On 04/21/2014 04:02 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote: File-private locks have been merged into Linux for v3.15, and *now*

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
On Mon, 21 Apr 2014 20:18:50 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: Jeff, On 04/21/2014 06:45 PM, Jeff Layton wrote: On Mon, 21 Apr 2014 12:10:04 -0400 Rich Felker dal...@libc.org wrote: On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages)

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Christoph Hellwig
On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: So, can you *please* answer this question: what do you call (i.e., what everyday technical language term do use for) the thing that sits between a file descriptor and an i-node? An open file. -- To unsubscribe

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 08:34 PM, Christoph Hellwig wrote: On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: So, can you *please* answer this question: what do you call (i.e., what everyday technical language term do use for) the thing that sits between a file descriptor and

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 08:01 PM, Andy Lutomirski wrote: On 04/21/2014 09:45 AM, Jeff Layton wrote: On Mon, 21 Apr 2014 12:10:04 -0400 Rich Felker dal...@libc.org wrote: I'm well aware of that. The problem is that the proposed API is using the two-letter abbreviation FD, which ALWAYS means file

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: On 04/21/2014 06:10 PM, Rich Felker wrote: I'm well aware of that. The problem is that the proposed API is using the two-letter abbreviation FD, which ALWAYS means file descriptor and NEVER means file description

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 02:32:38PM -0400, Jeff Layton wrote: Fair enough. Assuming we kept file-description locks as a name, what would you propose as new macro names? I assume you meant, assume we kept the term 'file-private locks'... In that case, at least make the constants

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Theodore Ts'o
On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: So, can you *please* answer this question: what do you call (i.e., what everyday technical language term do use for) the thing that sits between a file descriptor and an i-node? (Please don't say 'struct file' --

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 02:48:41PM -0400, Theodore Ts'o wrote: On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: So, can you *please* answer this question: what do you call (i.e., what everyday technical language term do use for) the thing that sits between a

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Theodore Ts'o
On Mon, Apr 21, 2014 at 02:51:44PM -0400, Rich Felker wrote: I don't think struct file has any meaning to any userspace developers, and as such doesn't belong in documentation for userspace programming. It's an implementation detail of the kernel that userspace developers have no need to be

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Christoph Hellwig
On Mon, Apr 21, 2014 at 03:04:10PM -0400, Theodore Ts'o wrote: I think what you mean is that there is no need that we expose the name struct file. My point is that struct file is actually a much _better_ name than file description. Heck, open file object would be better name than file

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
On Mon, 21 Apr 2014 14:48:29 -0400 Rich Felker dal...@libc.org wrote: On Mon, Apr 21, 2014 at 02:32:38PM -0400, Jeff Layton wrote: Fair enough. Assuming we kept file-description locks as a name, what would you propose as new macro names? I assume you meant, assume we kept the term

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 08:46 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: On 04/21/2014 06:10 PM, Rich Felker wrote: I'm well aware of that. The problem is that the proposed API is using the two-letter abbreviation FD, which ALWAYS means file

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Jeff Layton
On Mon, 21 Apr 2014 21:39:12 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/21/2014 08:46 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: On 04/21/2014 06:10 PM, Rich Felker wrote: I'm well aware of that. The

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 09:06 PM, Christoph Hellwig wrote: On Mon, Apr 21, 2014 at 03:04:10PM -0400, Theodore Ts'o wrote: I think what you mean is that there is no need that we expose the name struct file. My point is that struct file is actually a much _better_ name than file description. Heck, open

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 03:16:29PM -0400, Jeff Layton wrote: On Mon, 21 Apr 2014 14:48:29 -0400 Rich Felker dal...@libc.org wrote: On Mon, Apr 21, 2014 at 02:32:38PM -0400, Jeff Layton wrote: Fair enough. Assuming we kept file-description locks as a name, what would you propose as

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Rich Felker
On Mon, Apr 21, 2014 at 03:04:10PM -0400, Theodore Ts'o wrote: On Mon, Apr 21, 2014 at 02:51:44PM -0400, Rich Felker wrote: I don't think struct file has any meaning to any userspace developers, and as such doesn't belong in documentation for userspace programming. It's an implementation

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Stefan (metze) Metzmacher
Am 21.04.2014 21:55, schrieb Jeff Layton: On Mon, 21 Apr 2014 21:39:12 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/21/2014 08:46 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: On 04/21/2014 06:10 PM, Rich Felker

Re: [PATCH] locks: rename file-private locks to file-description locks

2014-04-21 Thread Michael Kerrisk (man-pages)
On 04/21/2014 11:15 PM, Stefan (metze) Metzmacher wrote: Am 21.04.2014 21:55, schrieb Jeff Layton: On Mon, 21 Apr 2014 21:39:12 +0200 Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote: On 04/21/2014 08:46 PM, Rich Felker wrote: On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk