Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-10-01 Thread Jeff Moyer
Jens Axboe writes: > On 2012-09-28 17:02, Jeff Moyer wrote: >> Jens Axboe writes: >> >>> On 2012-09-28 08:09, Dave Chinner wrote: From: Dave Chinner xfstests has always had random failures of tests due to loop devices failing to be torn down and hence leaving filesytems

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-10-01 Thread Jeff Moyer
Jens Axboe ax...@kernel.dk writes: On 2012-09-28 17:02, Jeff Moyer wrote: Jens Axboe ax...@kernel.dk writes: On 2012-09-28 08:09, Dave Chinner wrote: From: Dave Chinner dchin...@redhat.com xfstests has always had random failures of tests due to loop devices failing to be torn down and

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Jens Axboe
On 2012-09-28 16:38, Dave Jones wrote: > On Fri, Sep 28, 2012 at 10:41:50AM +0200, Jens Axboe wrote: > > > > Turns out that blkid is running simultaneously with losetup -d, and > > > so it sees an elevated reference count and returns EBUSY. But why > > > is blkid running? It's obvious, isn't

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Jens Axboe
On 2012-09-28 17:02, Jeff Moyer wrote: > Jens Axboe writes: > >> On 2012-09-28 08:09, Dave Chinner wrote: >>> From: Dave Chinner >>> >>> xfstests has always had random failures of tests due to loop devices >>> failing to be torn down and hence leaving filesytems that cannot be >>> unmounted.

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Jeff Moyer
Jens Axboe writes: > On 2012-09-28 08:09, Dave Chinner wrote: >> From: Dave Chinner >> >> xfstests has always had random failures of tests due to loop devices >> failing to be torn down and hence leaving filesytems that cannot be >> unmounted. This causes test runs to immediately stop. >> >>

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Dave Jones
On Fri, Sep 28, 2012 at 10:41:50AM +0200, Jens Axboe wrote: > > Turns out that blkid is running simultaneously with losetup -d, and > > so it sees an elevated reference count and returns EBUSY. But why > > is blkid running? It's obvious, isn't it? udev has decided to try > > and find out

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Jens Axboe
On 2012-09-28 08:09, Dave Chinner wrote: > From: Dave Chinner > > xfstests has always had random failures of tests due to loop devices > failing to be torn down and hence leaving filesytems that cannot be > unmounted. This causes test runs to immediately stop. > > Over the past 6 or 7 years

[PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Dave Chinner
From: Dave Chinner xfstests has always had random failures of tests due to loop devices failing to be torn down and hence leaving filesytems that cannot be unmounted. This causes test runs to immediately stop. Over the past 6 or 7 years we've added hacks like explicit unmount -d commands for

[PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Dave Chinner
From: Dave Chinner dchin...@redhat.com xfstests has always had random failures of tests due to loop devices failing to be torn down and hence leaving filesytems that cannot be unmounted. This causes test runs to immediately stop. Over the past 6 or 7 years we've added hacks like explicit unmount

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Jens Axboe
On 2012-09-28 08:09, Dave Chinner wrote: From: Dave Chinner dchin...@redhat.com xfstests has always had random failures of tests due to loop devices failing to be torn down and hence leaving filesytems that cannot be unmounted. This causes test runs to immediately stop. Over the past 6 or

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Dave Jones
On Fri, Sep 28, 2012 at 10:41:50AM +0200, Jens Axboe wrote: Turns out that blkid is running simultaneously with losetup -d, and so it sees an elevated reference count and returns EBUSY. But why is blkid running? It's obvious, isn't it? udev has decided to try and find out what is on

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Jeff Moyer
Jens Axboe ax...@kernel.dk writes: On 2012-09-28 08:09, Dave Chinner wrote: From: Dave Chinner dchin...@redhat.com xfstests has always had random failures of tests due to loop devices failing to be torn down and hence leaving filesytems that cannot be unmounted. This causes test runs to

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Jens Axboe
On 2012-09-28 17:02, Jeff Moyer wrote: Jens Axboe ax...@kernel.dk writes: On 2012-09-28 08:09, Dave Chinner wrote: From: Dave Chinner dchin...@redhat.com xfstests has always had random failures of tests due to loop devices failing to be torn down and hence leaving filesytems that cannot be

Re: [PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Jens Axboe
On 2012-09-28 16:38, Dave Jones wrote: On Fri, Sep 28, 2012 at 10:41:50AM +0200, Jens Axboe wrote: Turns out that blkid is running simultaneously with losetup -d, and so it sees an elevated reference count and returns EBUSY. But why is blkid running? It's obvious, isn't it? udev