On 08/07/2017 06:37 AM, Anton Volkov wrote:
> The early device registration made possible a race leading to allocations
> of disks with wrong minors.
>
> This patch moves the device registration further down the loop_init
> function to make the race infeasible.
>
> Found by Linux Driver Verificat
Hello, Omar.
It was a purely theoretical race that had been considered to be possible
in real-life.
Regards,
Anton
On 09.08.2017 01:00, Omar Sandoval wrote:
On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote:
The early device registration made possible a race leading to allocation
On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote:
> The early device registration made possible a race leading to allocations
> of disks with wrong minors.
>
> This patch moves the device registration further down the loop_init
> function to make the race infeasible.
>
> Found by Linu
On Mon, Aug 07, 2017 at 04:09:12PM +0300, Anton Volkov wrote:
> This is more of a style-oriented suggestion. This kind of template is
> commonly used in other modules.
Yes but there is no point in using gotos here (i.e. cleanup to be done), you
an just return directly.
And yes it is a minor nit.
This is more of a style-oriented suggestion. This kind of template is
commonly used in other modules.
Regards,
Anton
On 07.08.2017 15:54, Johannes Thumshirn wrote:
On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote:
+err_out:
return err;
Any reason you can't just use retur
On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote:
> +err_out:
> return err;
Any reason you can't just use return err; at the respective callsites?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de
The early device registration made possible a race leading to allocations
of disks with wrong minors.
This patch moves the device registration further down the loop_init
function to make the race infeasible.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Volk
On Thu, Aug 3, 2017 at 11:01 PM, Anton Volkov wrote:
> The early device registration made possible a race leading to allocations
> of disks with wrong minors.
>
> This patch moves the device registration further down the loop_init
> function to make the race infeasible.
>
> Found by Linux Driver V
The early device registration made possible a race leading to allocations
of disks with wrong minors.
This patch moves the device registration further down the loop_init
function to make the race infeasible.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Volk
9 matches
Mail list logo