Re: [PATCH] lsm: copy comm before calling audit_log to avoid race in string printing

2015-04-14 Thread James Morris
On Tue, 14 Apr 2015, Richard Guy Briggs wrote: > When task->comm is passed directly to audit_log_untrustedstring() without > getting a copy or using the task_lock, there is a race that could happen that > would output a NULL (\0) in the middle of the output string that would > effectively truncate

[PATCH] lsm: copy comm before calling audit_log to avoid race in string printing

2015-04-14 Thread Richard Guy Briggs
When task->comm is passed directly to audit_log_untrustedstring() without getting a copy or using the task_lock, there is a race that could happen that would output a NULL (\0) in the middle of the output string that would effectively truncate the rest of the report text after the comm= field in th

Re: [PATCH] lsm: copy comm before calling audit_log to avoid race in string printing

2014-11-25 Thread Paul Moore
On Sunday, November 16, 2014 04:44:10 PM Richard Guy Briggs wrote: > When task->comm is passed directly to audit_log_untrustedstring() without > getting a copy or using the task_lock, there is a race that could happen > that would output a NULL (\0) in the middle of the output string that would > e

[PATCH] lsm: copy comm before calling audit_log to avoid race in string printing

2014-11-16 Thread Richard Guy Briggs
When task->comm is passed directly to audit_log_untrustedstring() without getting a copy or using the task_lock, there is a race that could happen that would output a NULL (\0) in the middle of the output string that would effectively truncate the rest of the report text after the comm= field in th