Re: [PATCH] mac80211: check endianness/types in sparse runs

2008-02-22 Thread Johannes Berg
> > In any case, I would love to have __CHECK_ENDIAN__ enabled by default at > > least on the wireless code (just caught another bug with it...) > > So build with make C=2 -D__CHECK_ENDIAN__ net/ieee80211/, etc. - it's not > that such a script would be tricky... It's not that I don't know how to

Re: [PATCH] mac80211: check endianness/types in sparse runs

2008-02-21 Thread Al Viro
On Thu, Feb 21, 2008 at 01:42:56PM +0100, Johannes Berg wrote: > >> [patch doing CHECKFLAGS += -D__CHECK_ENDIAN__ in the > >> net/mac80211/Makefile] > > > I would prefer it to be kernel wide enabled. > > Tried a defconfig build. > > Hm. I tend to think there was a reason for this, since this is a

Re: [PATCH] mac80211: check endianness/types in sparse runs

2008-02-21 Thread Harvey Harrison
On Thu, 2008-02-21 at 21:29 +0100, Johannes Berg wrote: > > Clean, or did you specifically mean bitwise-clean? > > bitwise-clean. But I don't do full-mac drivers so most of what you quote > I don't compile, and the mac80211-based drivers only have few problems. > This wasn't meant as any sort of

Re: [PATCH] mac80211: check endianness/types in sparse runs

2008-02-21 Thread Johannes Berg
> Clean, or did you specifically mean bitwise-clean? bitwise-clean. But I don't do full-mac drivers so most of what you quote I don't compile, and the mac80211-based drivers only have few problems. johannes signature.asc Description: This is a digitally signed message part

Re: [PATCH] mac80211: check endianness/types in sparse runs

2008-02-21 Thread Harvey Harrison
On Thu, 2008-02-21 at 21:09 +0100, Johannes Berg wrote: > > > In any case, I would love to have __CHECK_ENDIAN__ enabled by default at > > > least on the wireless code (just caught another bug with it...) > > > > I should then add support for something like: > > > > checkflags-y := -D__CHECK_ENDI

Re: [PATCH] mac80211: check endianness/types in sparse runs

2008-02-21 Thread Johannes Berg
> > In any case, I would love to have __CHECK_ENDIAN__ enabled by default at > > least on the wireless code (just caught another bug with it...) > > I should then add support for something like: > > checkflags-y := -D__CHECK_ENDIAN__ > > to match the style of the rest. > > I do not like all th

Re: [PATCH] mac80211: check endianness/types in sparse runs

2008-02-21 Thread Sam Ravnborg
On Thu, Feb 21, 2008 at 01:42:56PM +0100, Johannes Berg wrote: > >> [patch doing CHECKFLAGS += -D__CHECK_ENDIAN__ in the > >> net/mac80211/Makefile] > > > I would prefer it to be kernel wide enabled. > > Tried a defconfig build. > > Hm. I tend to think there was a reason for this, since this is a

Re: [PATCH] mac80211: check endianness/types in sparse runs

2008-02-21 Thread Harvey Harrison
On Thu, 2008-02-21 at 13:42 +0100, Johannes Berg wrote: > >> [patch doing CHECKFLAGS += -D__CHECK_ENDIAN__ in the > >> net/mac80211/Makefile] > > > I would prefer it to be kernel wide enabled. > > Tried a defconfig build. > > Hm. I tend to think there was a reason for this, since this is actually

Re: [PATCH] mac80211: check endianness/types in sparse runs

2008-02-21 Thread Johannes Berg
>> [patch doing CHECKFLAGS += -D__CHECK_ENDIAN__ in the >> net/mac80211/Makefile] > I would prefer it to be kernel wide enabled. > Tried a defconfig build. Hm. I tend to think there was a reason for this, since this is actually explicitly disabled by include/linux/types.h: #ifdef __CHECKER__ #de