Re: [PATCH] mac80211: fix invalid read in minstrel_sort_best_tp_rates()

2015-08-13 Thread Johannes Berg
On Tue, 2015-07-28 at 10:30 +0200, Adrien Schildknecht wrote: > At the last iteration of the loop, j may equal zero and thus > tp_list[j - 1] causes an invalid read. > Changed the logic of the loop so that j - 1 is always >= 0. > > Signed-off-by: Adrien Schildknecht > Applied, I added Cc

Re: [PATCH] mac80211: fix invalid read in minstrel_sort_best_tp_rates()

2015-08-13 Thread Johannes Berg
On Tue, 2015-07-28 at 10:30 +0200, Adrien Schildknecht wrote: At the last iteration of the loop, j may equal zero and thus tp_list[j - 1] causes an invalid read. Changed the logic of the loop so that j - 1 is always = 0. Signed-off-by: Adrien Schildknecht adrien+...@schischi.me Applied, I

[PATCH] mac80211: fix invalid read in minstrel_sort_best_tp_rates()

2015-07-28 Thread Adrien Schildknecht
At the last iteration of the loop, j may equal zero and thus tp_list[j - 1] causes an invalid read. Changed the logic of the loop so that j - 1 is always >= 0. Signed-off-by: Adrien Schildknecht --- net/mac80211/rc80211_minstrel.c | 11 ++- 1 file changed, 6 insertions(+), 5

[PATCH] mac80211: fix invalid read in minstrel_sort_best_tp_rates()

2015-07-28 Thread Adrien Schildknecht
At the last iteration of the loop, j may equal zero and thus tp_list[j - 1] causes an invalid read. Changed the logic of the loop so that j - 1 is always = 0. Signed-off-by: Adrien Schildknecht adrien+...@schischi.me --- net/mac80211/rc80211_minstrel.c | 11 ++- 1 file changed, 6