Re: [PATCH] macintosh/mediabay: Convert to kthread API.

2007-04-20 Thread Benjamin Herrenschmidt
> Looks OK - there's no way of stopping the kernel thread anyway. > > It appears that nobody has tried to use this driver at the same time as > software-suspend. At least, not successfully. A strategic try_to_freeze() > should fix it. > > This will become (a little) more serious when cpu

Re: [PATCH] macintosh/mediabay: Convert to kthread API.

2007-04-20 Thread Benjamin Herrenschmidt
Looks OK - there's no way of stopping the kernel thread anyway. It appears that nobody has tried to use this driver at the same time as software-suspend. At least, not successfully. A strategic try_to_freeze() should fix it. This will become (a little) more serious when cpu hotplug is

Re: [PATCH] macintosh/mediabay: Convert to kthread API.

2007-04-19 Thread Andrew Morton
On Thu, 19 Apr 2007 01:58:50 -0600 "Eric W. Biederman" <[EMAIL PROTECTED]> wrote: > This patch modifies the startup of the media_bay_task > to use kthread_run and not a combination of kernel_thread, > deamonize and sigfillset. > > In addition since we now always want to ignore signals > the

[PATCH] macintosh/mediabay: Convert to kthread API.

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> This patch modifies the startup of the media_bay_task to use kthread_run and not a combination of kernel_thread, deamonize and sigfillset. In addition since we now always want to ignore signals the MB_IGNORE_SIGNALS define is removed along with the

[PATCH] macintosh/mediabay: Convert to kthread API.

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This patch modifies the startup of the media_bay_task to use kthread_run and not a combination of kernel_thread, deamonize and sigfillset. In addition since we now always want to ignore signals the MB_IGNORE_SIGNALS define is removed along

[PATCH] macintosh/mediabay: Convert to kthread API.

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted This patch modifies the startup of the media_bay_task to use kthread_run and not a combination of kernel_thread, deamonize and sigfillset. In addition since we now always want to ignore signals the MB_IGNORE_SIGNALS define is removed along

[PATCH] macintosh/mediabay: Convert to kthread API.

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] This patch modifies the startup of the media_bay_task to use kthread_run and not a combination of kernel_thread, deamonize and sigfillset. In addition since we now always want to ignore signals the MB_IGNORE_SIGNALS define is removed along with the test

Re: [PATCH] macintosh/mediabay: Convert to kthread API.

2007-04-19 Thread Andrew Morton
On Thu, 19 Apr 2007 01:58:50 -0600 Eric W. Biederman [EMAIL PROTECTED] wrote: This patch modifies the startup of the media_bay_task to use kthread_run and not a combination of kernel_thread, deamonize and sigfillset. In addition since we now always want to ignore signals the