Re: [PATCH] madvise_need_mmap_write() usage

2007-06-18 Thread Nish Aravamudan
On 6/18/07, Jason Baron <[EMAIL PROTECTED]> wrote: On Sat, 16 Jun 2007, Christoph Hellwig wrote: > On Fri, Jun 15, 2007 at 11:20:31AM -0400, Jason Baron wrote: > > hi, > > > > i was just looking at the new madvise_need_mmap_write() call...can we > > avoid an extra case statement and function ca

Re: [PATCH] madvise_need_mmap_write() usage

2007-06-18 Thread Jason Baron
On Sat, 16 Jun 2007, Christoph Hellwig wrote: > On Fri, Jun 15, 2007 at 11:20:31AM -0400, Jason Baron wrote: > > hi, > > > > i was just looking at the new madvise_need_mmap_write() call...can we > > avoid an extra case statement and function call as follows? > > Sounds like a good idea, but ple

Re: [PATCH] madvise_need_mmap_write() usage

2007-06-16 Thread Christoph Hellwig
On Fri, Jun 15, 2007 at 11:20:31AM -0400, Jason Baron wrote: > hi, > > i was just looking at the new madvise_need_mmap_write() call...can we > avoid an extra case statement and function call as follows? Sounds like a good idea, but please move the assignment out of the conditional. - To unsubscr

[PATCH] madvise_need_mmap_write() usage

2007-06-15 Thread Jason Baron
hi, i was just looking at the new madvise_need_mmap_write() call...can we avoid an extra case statement and function call as follows? thanks, -Jason Signed-off-by: Jason Baron <[EMAIL PROTECTED]> diff --git a/mm/madvise.c b/mm/madvise.c --- a/mm/madvise.c +++ b/mm/madvise.c @@ -287,9 +287,10