Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Jassi Brar
On Thu, Nov 2, 2017 at 6:07 PM, Sudeep Holla wrote: > On 02/11/17 12:21, Jassi Brar wrote: >> On Thu, Nov 2, 2017 at 5:19 PM, Sudeep Holla wrote: >>> On 02/11/17 11:26, Jassi Brar wrote: >> >> 1) Where does the "whatever_value_to_trigger_signal" come from? > > Controller specific. >

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Sudeep Holla
On 02/11/17 12:21, Jassi Brar wrote: > On Thu, Nov 2, 2017 at 5:19 PM, Sudeep Holla wrote: >> On 02/11/17 11:26, Jassi Brar wrote: > > 1) Where does the "whatever_value_to_trigger_signal" come from? Controller specific. > That has to come from client. No.

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Jassi Brar
On Thu, Nov 2, 2017 at 5:19 PM, Sudeep Holla wrote: > On 02/11/17 11:26, Jassi Brar wrote: 1) Where does the "whatever_value_to_trigger_signal" come from? >>> >>> Controller specific. >>> That has to come from client. >>> >>> No. >>> >> Again, let me know what does the controller expe

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Sudeep Holla
On 02/11/17 11:26, Jassi Brar wrote: > On Thu, Nov 2, 2017 at 4:17 PM, Sudeep Holla wrote: [...] >> >> No that non-zero value is not client specific, it's entirely controller >> specific. >> > ?? > For example BCM2835 has such a controller. Have a look at > bcm2835_send_data() and let me know

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Jassi Brar
On Thu, Nov 2, 2017 at 4:17 PM, Sudeep Holla wrote: > On 02/11/17 02:39, Jassi Brar wrote: > > Such controllers don't need to transmit any data, they just transmit > the signal. In such controllers the data pointer passed to > mbox_send_message is passed to client via it's tx_prep

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Sudeep Holla
On 01/11/17 22:12, Bjorn Andersson wrote: > On Wed 01 Nov 11:03 PDT 2017, Jassi Brar wrote: >> On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: > [..] >>> >>> This is rough idea I have on extending mailbox interface to support >>> the doorbell requirements. >>> >> What doorbell requirements

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Sudeep Holla
On 02/11/17 02:39, Jassi Brar wrote: > On Wed, Nov 1, 2017 at 11:45 PM, Sudeep Holla wrote: >> >> >> On 01/11/17 18:03, Jassi Brar wrote: >>> On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: >>> Such controllers don't need to transmit any data, they just transmit the signal.

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Thu, Nov 2, 2017 at 8:57 AM, Bjorn Andersson wrote: > On Wed 01 Nov 20:02 PDT 2017, Jassi Brar wrote: > >> On Thu, Nov 2, 2017 at 3:47 AM, Bjorn Andersson >> wrote: >> > On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote: >> >> >> >> 80 writel_relaxed(msg->cmd, mb->mbox_base + >> >> MAI

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Bjorn Andersson
On Wed 01 Nov 20:02 PDT 2017, Jassi Brar wrote: > On Thu, Nov 2, 2017 at 3:47 AM, Bjorn Andersson > wrote: > > On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote: > >> > >> 80 writel_relaxed(msg->cmd, mb->mbox_base + > >> MAILBOX_A2B_CMD(chans->idx)); > >> 81 writel_relaxed(msg->r

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Thu, Nov 2, 2017 at 3:47 AM, Bjorn Andersson wrote: > On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote: >> >> 80 writel_relaxed(msg->cmd, mb->mbox_base + >> MAILBOX_A2B_CMD(chans->idx)); >> 81 writel_relaxed(msg->rx_size, mb->mbox_base + >> >> 82MAILBO

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Thu, Nov 2, 2017 at 3:42 AM, Bjorn Andersson wrote: > On Wed 01 Nov 11:03 PDT 2017, Jassi Brar wrote: >> On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: > [..] >> > >> > This is rough idea I have on extending mailbox interface to support >> > the doorbell requirements. >> > >> What doorbe

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Wed, Nov 1, 2017 at 11:45 PM, Sudeep Holla wrote: > > > On 01/11/17 18:03, Jassi Brar wrote: >> On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: >> >>> >>> Such controllers don't need to transmit any data, they just transmit >>> the signal. In such controllers the data pointer passed to >>

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Bjorn Andersson
On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote: > > 80 writel_relaxed(msg->cmd, mb->mbox_base + > MAILBOX_A2B_CMD(chans->idx)); > 81 writel_relaxed(msg->rx_size, mb->mbox_base + > > 82MAILBOX_A2B_DAT(chans->idx)); > > 83 This is just terrible, using

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Bjorn Andersson
On Wed 01 Nov 11:03 PDT 2017, Jassi Brar wrote: > On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: [..] > > > > This is rough idea I have on extending mailbox interface to support > > the doorbell requirements. > > > What doorbell requirements does the api not support? > QComm's APCS IPC is wh

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Sudeep Holla
On 01/11/17 18:03, Jassi Brar wrote: > On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: > >> >> Such controllers don't need to transmit any data, they just transmit >> the signal. In such controllers the data pointer passed to >> mbox_send_message is passed to client via it's tx_prepare cal

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: > > Such controllers don't need to transmit any data, they just transmit > the signal. In such controllers the data pointer passed to > mbox_send_message is passed to client via it's tx_prepare callback. > Controller doesn't need any data to be

[PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Sudeep Holla
Some mailbox controllers are lack FIFOs or memory to transmit data. They typically contains single doorbell registers to just signal the remote. The actually data is transmitted/shared using some shared memory which is not part of the mailbox. Such controllers don't need to transmit any data, they