Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Jerome Brunet
On Fri 16 Oct 2020 at 20:45, Jassi Brar wrote: > On Fri, Oct 16, 2020 at 1:38 PM Jerome Brunet wrote: >> >> >> On Fri 16 Oct 2020 at 19:30, jassisinghb...@gmail.com wrote: >> >> > From: Jassi Brar >> > >> > If the txdone is done by polling, it is possible for msg_submit() to start >> > the

Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Jassi Brar
On Fri, Oct 16, 2020 at 1:38 PM Jerome Brunet wrote: > > > On Fri 16 Oct 2020 at 19:30, jassisinghb...@gmail.com wrote: > > > From: Jassi Brar > > > > If the txdone is done by polling, it is possible for msg_submit() to start > > the timer while txdone_hrtimer() callback is running. If the timer

Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Jerome Brunet
On Fri 16 Oct 2020 at 19:30, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > If the txdone is done by polling, it is possible for msg_submit() to start > the timer while txdone_hrtimer() callback is running. If the timer needs > recheduling, it could already be enqueued by the time

Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Jassi Brar
On Fri, Oct 16, 2020 at 12:50 PM Sudeep Holla wrote: > > On Fri, Oct 16, 2020 at 12:30:20PM -0500, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > If the txdone is done by polling, it is possible for msg_submit() to start > > the timer while txdone_hrtimer() callback is running. If

Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Sudeep Holla
On Fri, Oct 16, 2020 at 12:30:20PM -0500, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > If the txdone is done by polling, it is possible for msg_submit() to start > the timer while txdone_hrtimer() callback is running. If the timer needs > recheduling, it could already be enqueued by

[PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread jassisinghbrar
From: Jassi Brar If the txdone is done by polling, it is possible for msg_submit() to start the timer while txdone_hrtimer() callback is running. If the timer needs recheduling, it could already be enqueued by the time hrtimer_forward_now() is called, leading hrtimer to loudly complain.