On Sun, 7 Jan 2007 19:58:45 + Christoph Hellwig wrote:
> On Sun, Jan 07, 2007 at 11:19:00AM -0800, Randy Dunlap wrote:
> > On Sun, 7 Jan 2007 20:12:42 +0100 Segher Boessenkool wrote:
> >
> > > There's an extra tab in that last line. Could you also
> > > please fix the indenting (use a tab, n
On Sun, Jan 07, 2007 at 11:19:00AM -0800, Randy Dunlap wrote:
> On Sun, 7 Jan 2007 20:12:42 +0100 Segher Boessenkool wrote:
>
> > There's an extra tab in that last line. Could you also
> > please fix the indenting (use a tab, not spaces) -- I know
> > it was there originally, but since there are
On Sun, 7 Jan 2007 20:29:21 +0100 Segher Boessenkool wrote:
> >> There's an extra tab in that last line. Could you also
> >> please fix the indenting (use a tab, not spaces) -- I know
> >> it was there originally, but since there are only a few
> >> lines in that file like that... :-)
> >
> > ho
There's an extra tab in that last line. Could you also
please fix the indenting (use a tab, not spaces) -- I know
it was there originally, but since there are only a few
lines in that file like that... :-)
how's this one?
I meant fix all the wrongly indented lines in that file (there
are onl
On Sun, 7 Jan 2007, Randy Dunlap wrote:
> On Sun, 7 Jan 2007 20:12:42 +0100 Segher Boessenkool wrote:
>
> > There's an extra tab in that last line. Could you also
> > please fix the indenting (use a tab, not spaces) -- I know
> > it was there originally, but since there are only a few
> > lines i
On Sun, 7 Jan 2007 20:12:42 +0100 Segher Boessenkool wrote:
> There's an extra tab in that last line. Could you also
> please fix the indenting (use a tab, not spaces) -- I know
> it was there originally, but since there are only a few
> lines in that file like that... :-)
how's this one?
---
F
-#define setcc(cc) ({ \
+#define setcc(cc) do { \
partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \
- partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); })
+ partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); \
+ } while (0)
There's an extra tab in that last line. Could you also
plea
On Sun, 7 Jan 2007 14:27:32 +0100 Segher Boessenkool wrote:
> closing brace on the "while" line, please.
---
From: Randy Dunlap <[EMAIL PROTECTED]>
setcc() in math-emu is written as a gcc extension statement expression
macro that returns a value. However, it's not used that way and it's
not nee
setcc() in math-emu is written as a gcc extension statement expression
macro that returns a value. However, it's not used that way and it's
not needed like that, so just make it a do-while non-extension macro
so that we don't use an extension when it's not needed.
Looks fine, except
-#define
From: Randy Dunlap <[EMAIL PROTECTED]>
setcc() in math-emu is written as a gcc extension statement expression
macro that returns a value. However, it's not used that way and it's
not needed like that, so just make it a do-while non-extension macro
so that we don't use an extension when it's not n
10 matches
Mail list logo