Re: [PATCH] mcb: Fix an error handling path in 'chameleon_parse_cells()'

2017-08-28 Thread Johannes Thumshirn
Applied to mcb-for-4.14 branch. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton

Re: [PATCH] mcb: Fix an error handling path in 'chameleon_parse_cells()'

2017-08-28 Thread Johannes Thumshirn
Applied to mcb-for-4.14 branch. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton

[PATCH] mcb: Fix an error handling path in 'chameleon_parse_cells()'

2017-08-16 Thread Christophe JAILLET
If 'chameleon_get_bar()' fails, we will return 0, which mean success. We should return the corresponding error code instead. Remove the useless initialisation of 'ret' which was hiding the issue. (if 'ret' is not set, gcc generates a warning ("warning: ‘ret’ may be used uninitialized in this

[PATCH] mcb: Fix an error handling path in 'chameleon_parse_cells()'

2017-08-16 Thread Christophe JAILLET
If 'chameleon_get_bar()' fails, we will return 0, which mean success. We should return the corresponding error code instead. Remove the useless initialisation of 'ret' which was hiding the issue. (if 'ret' is not set, gcc generates a warning ("warning: ‘ret’ may be used uninitialized in this