Re: [PATCH] mct232: speed, new termios and compliance cleanups

2007-11-20 Thread Alan Cox
> > * we do not know how to support. We ignore them for the moment. > > * XXX Rate-limit the error message, it's user triggerable. > > This XXX item is fixed by this patch, so should be removed. Ok > > > + /* FIXME: Can we use any divider - should we do > > + divider

Re: [PATCH] mct232: speed, new termios and compliance cleanups

2007-11-20 Thread Pete Zaitcev
On Mon, 19 Nov 2007 15:22:11 +, Alan Cox <[EMAIL PROTECTED]> wrote: > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> This looks good, but have a couple of comments. Maybe I can fix it up. > * we do not know how to support. We ignore them for the moment. > * XXX Rate-limit the error

Re: [PATCH] mct232: speed, new termios and compliance cleanups

2007-11-20 Thread Pete Zaitcev
On Mon, 19 Nov 2007 15:22:11 +, Alan Cox [EMAIL PROTECTED] wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] This looks good, but have a couple of comments. Maybe I can fix it up. * we do not know how to support. We ignore them for the moment. * XXX Rate-limit the error message, it's

Re: [PATCH] mct232: speed, new termios and compliance cleanups

2007-11-20 Thread Alan Cox
* we do not know how to support. We ignore them for the moment. * XXX Rate-limit the error message, it's user triggerable. This XXX item is fixed by this patch, so should be removed. Ok + /* FIXME: Can we use any divider - should we do + divider =

[PATCH] mct232: speed, new termios and compliance cleanups

2007-11-19 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/usb/serial/mct_u232.c linux-2.6.24-rc2-mm1/drivers/usb/serial/mct_u232.c --- linux.vanilla-2.6.24-rc2-mm1/drivers/usb/serial/mct_u232.c 2007-11-16

[PATCH] mct232: speed, new termios and compliance cleanups

2007-11-19 Thread Alan Cox
Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/usb/serial/mct_u232.c linux-2.6.24-rc2-mm1/drivers/usb/serial/mct_u232.c --- linux.vanilla-2.6.24-rc2-mm1/drivers/usb/serial/mct_u232.c 2007-11-16